You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/11/19 23:22:49 UTC
Review Request 15684: Python CLI helper 'http.get' should not assume JSON.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15684/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Du Li, Shingo Omura, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/cli/mesos-cat bb1e19750083f9e2680a5a22bd3bd3f7b2bc8656
src/cli/mesos-ps aff8423040a4ba5ce7f41da73a4c70a4d76da93f
src/cli/mesos-tail 33acee4f92a1fa0cbf65568537e24f822e083717
src/cli/python/mesos/http.py e65701bee92dcad2af4e871394df5c60a7150659
Diff: https://reviews.apache.org/r/15684/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request 15684: Python CLI helper 'http.get' should not assume
JSON.
Posted by Du Li <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15684/#review29144
-----------------------------------------------------------
Ship it!
let the client check it even if the content is empty.
- Du Li
On Nov. 19, 2013, 10:22 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15684/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:22 p.m.)
>
>
> Review request for mesos, Ben Mahler, Du Li, Shingo Omura, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-cat bb1e19750083f9e2680a5a22bd3bd3f7b2bc8656
> src/cli/mesos-ps aff8423040a4ba5ce7f41da73a4c70a4d76da93f
> src/cli/mesos-tail 33acee4f92a1fa0cbf65568537e24f822e083717
> src/cli/python/mesos/http.py e65701bee92dcad2af4e871394df5c60a7150659
>
> Diff: https://reviews.apache.org/r/15684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 15684: Python CLI helper 'http.get' should not assume
JSON.
Posted by Shingo Omura <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15684/#review29145
-----------------------------------------------------------
Ship it!
Ship It!
- Shingo Omura
On Nov. 19, 2013, 10:22 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15684/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:22 p.m.)
>
>
> Review request for mesos, Ben Mahler, Du Li, Shingo Omura, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-cat bb1e19750083f9e2680a5a22bd3bd3f7b2bc8656
> src/cli/mesos-ps aff8423040a4ba5ce7f41da73a4c70a4d76da93f
> src/cli/mesos-tail 33acee4f92a1fa0cbf65568537e24f822e083717
> src/cli/python/mesos/http.py e65701bee92dcad2af4e871394df5c60a7150659
>
> Diff: https://reviews.apache.org/r/15684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 15684: Python CLI helper 'http.get' should not assume
JSON.
Posted by Du Li <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15684/#review29143
-----------------------------------------------------------
Ship it!
Ship It!
- Du Li
On Nov. 19, 2013, 10:22 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15684/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:22 p.m.)
>
>
> Review request for mesos, Ben Mahler, Du Li, Shingo Omura, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-cat bb1e19750083f9e2680a5a22bd3bd3f7b2bc8656
> src/cli/mesos-ps aff8423040a4ba5ce7f41da73a4c70a4d76da93f
> src/cli/mesos-tail 33acee4f92a1fa0cbf65568537e24f822e083717
> src/cli/python/mesos/http.py e65701bee92dcad2af4e871394df5c60a7150659
>
> Diff: https://reviews.apache.org/r/15684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 15684: Python CLI helper 'http.get' should not assume
JSON.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15684/#review29146
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Nov. 19, 2013, 10:22 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15684/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 10:22 p.m.)
>
>
> Review request for mesos, Ben Mahler, Du Li, Shingo Omura, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/cli/mesos-cat bb1e19750083f9e2680a5a22bd3bd3f7b2bc8656
> src/cli/mesos-ps aff8423040a4ba5ce7f41da73a4c70a4d76da93f
> src/cli/mesos-tail 33acee4f92a1fa0cbf65568537e24f822e083717
> src/cli/python/mesos/http.py e65701bee92dcad2af4e871394df5c60a7150659
>
> Diff: https://reviews.apache.org/r/15684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>