You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jeremy Thomerson <je...@wickettraining.com> on 2010/11/16 03:15:08 UTC
Maven license header plugin
Right now we have the license header test that fails if we forget to add a
license header. But, the last time I checked, I didn't see an easy way to
automate the license header additions. Would anyone be opposed to me using
the license header plugin [1] in our pom? I've used it on other projects
and love it. We could, optionally, remove the license header test since the
license plugin can be configured to easily fail the build if you've
forgotten the headers. Thoughts?
[1] - http://code.google.com/p/maven-license-plugin/
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Maven license header plugin
Posted by Peter Ertl <pe...@gmx.org>.
does it respect file encoding (in case it matters) ?
Am 16.11.2010 um 18:58 schrieb Jeremy Thomerson:
> It works for all files: xml, html, sh, properties, java, etc, etc.
>
> Jeremy Thomerson
> http://wickettraining.com
> -- sent from my "smart" phone, so please excuse spelling, formatting, or
> compiler errors
>
> On Nov 16, 2010 11:38 AM, "Juergen Donnerstag" <ju...@gmail.com>
> wrote:
>
> Does it work for HTML files as well? Might be even more files are
> included in the test.
>
> -Juergen
>
>
> On Tue, Nov 16, 2010 at 3:44 PM, James Carman
>
> <ja...@carmanconsulting.com> wrote:
>> +1 to the maven plugin. And, yes IDEA does it too.
>>
>> On Tue...
Re: Maven license header plugin
Posted by Jeremy Thomerson <je...@wickettraining.com>.
It works for all files: xml, html, sh, properties, java, etc, etc.
Jeremy Thomerson
http://wickettraining.com
-- sent from my "smart" phone, so please excuse spelling, formatting, or
compiler errors
On Nov 16, 2010 11:38 AM, "Juergen Donnerstag" <ju...@gmail.com>
wrote:
Does it work for HTML files as well? Might be even more files are
included in the test.
-Juergen
On Tue, Nov 16, 2010 at 3:44 PM, James Carman
<ja...@carmanconsulting.com> wrote:
> +1 to the maven plugin. And, yes IDEA does it too.
>
> On Tue...
Re: Maven license header plugin
Posted by Juergen Donnerstag <ju...@gmail.com>.
Does it work for HTML files as well? Might be even more files are
included in the test.
-Juergen
On Tue, Nov 16, 2010 at 3:44 PM, James Carman
<ja...@carmanconsulting.com> wrote:
> +1 to the maven plugin. And, yes IDEA does it too.
>
> On Tue, Nov 16, 2010 at 8:15 AM, Martin Grigorov <mg...@apache.org> wrote:
>> On Tue, Nov 16, 2010 at 2:04 PM, James Carman <ja...@carmanconsulting.com>wrote:
>>
>>> On Tue, Nov 16, 2010 at 3:08 AM, Martin Grigorov <mg...@apache.org>
>>> wrote:
>>> >
>>> > Eclipse adds the licence for me when I create new files.
>>> >
>>>
>>> We don't all use Eclipse.
>>>
>> :-)
>>
>> I'm sure Intellij IDEA/Netbeans/... can do that too. Come on, even my vim
>> can do it :-)
>>
>> As I said - I'm +1 for using the Maven plugin if it does the same as the
>> unit test does.
>> I'd suggest to keep the unit test as disabled for a week or two until the
>> Maven plugin proves itself.
>>
>
Re: Maven license header plugin
Posted by James Carman <ja...@carmanconsulting.com>.
+1 to the maven plugin. And, yes IDEA does it too.
On Tue, Nov 16, 2010 at 8:15 AM, Martin Grigorov <mg...@apache.org> wrote:
> On Tue, Nov 16, 2010 at 2:04 PM, James Carman <ja...@carmanconsulting.com>wrote:
>
>> On Tue, Nov 16, 2010 at 3:08 AM, Martin Grigorov <mg...@apache.org>
>> wrote:
>> >
>> > Eclipse adds the licence for me when I create new files.
>> >
>>
>> We don't all use Eclipse.
>>
> :-)
>
> I'm sure Intellij IDEA/Netbeans/... can do that too. Come on, even my vim
> can do it :-)
>
> As I said - I'm +1 for using the Maven plugin if it does the same as the
> unit test does.
> I'd suggest to keep the unit test as disabled for a week or two until the
> Maven plugin proves itself.
>
Re: Maven license header plugin
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Nov 16, 2010 at 2:04 PM, James Carman <ja...@carmanconsulting.com>wrote:
> On Tue, Nov 16, 2010 at 3:08 AM, Martin Grigorov <mg...@apache.org>
> wrote:
> >
> > Eclipse adds the licence for me when I create new files.
> >
>
> We don't all use Eclipse.
>
:-)
I'm sure Intellij IDEA/Netbeans/... can do that too. Come on, even my vim
can do it :-)
As I said - I'm +1 for using the Maven plugin if it does the same as the
unit test does.
I'd suggest to keep the unit test as disabled for a week or two until the
Maven plugin proves itself.
Re: Maven license header plugin
Posted by James Carman <ja...@carmanconsulting.com>.
On Tue, Nov 16, 2010 at 3:08 AM, Martin Grigorov <mg...@apache.org> wrote:
>
> Eclipse adds the licence for me when I create new files.
>
We don't all use Eclipse.
Re: Maven license header plugin
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Nov 16, 2010 at 3:15 AM, Jeremy Thomerson <jeremy@wickettraining.com
> wrote:
> Right now we have the license header test that fails if we forget to add a
> license header. But, the last time I checked, I didn't see an easy way to
> automate the license header additions.
Eclipse adds the licence for me when I create new files.
> Would anyone be opposed to me using
> the license header plugin [1] in our pom? I've used it on other projects
> and love it. We could, optionally, remove the license header test since
> the
> license plugin can be configured to easily fail the build if you've
> forgotten the headers. Thoughts?
>
+1
>
> [1] - http://code.google.com/p/maven-license-plugin/
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>