You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/03/28 00:25:02 UTC

[jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack checkstyle-fixes

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/86

-- Commit Summary --

  * Fixes checkstyle violations in neutron.

-- File Changes --

    M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/ExternalGatewayInfo.java (2)
    M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Router.java (2)
    M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/RouterInterface.java (2)
    M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateRouterOptions.java (2)
    M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateRouterOptions.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/86.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/86.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Zack Shoylev <no...@github.com>.
merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38886166

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Andrew Gaul <no...@github.com>.
:+1:

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38878535

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Zack Shoylev <no...@github.com>.
About to merge

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38886042

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Zack Shoylev <no...@github.com>.
https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/188/org.apache.jclouds.labs$openstack-neutron/

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38875052

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Zack Shoylev <no...@github.com>.
Closed #86.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by Andrew Phillips <no...@github.com>.
Still a bunch of Checkstyle violations overall, but the [Neutron API is clean](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/188/org.apache.jclouds.labs$openstack-neutron/violations/) ;-) +1, good to go for me.

Thanks, @zack-shoylev!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38882185

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #188](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/188/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38874336

Re: [jclouds-labs-openstack] Fixes checkstyle violations in neutron. (#86)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-openstack #975](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/975/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/86#issuecomment-38874258