You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "ddupg (via GitHub)" <gi...@apache.org> on 2026/05/21 12:12:21 UTC

[PR] fix(bindings/nodejs): Align versioned list startAfter test [opendal]

ddupg opened a new pull request, #7579:
URL: https://github.com/apache/opendal/pull/7579

   # Which issue does this PR close?
   
   N/A. This fixes a CI-only behavior test regression after TOS versioning support was enabled.
   
   # Rationale for this change
   
   The Node.js binding `list with versions and start after` test was comparing `Entry[]` directly with path strings. It also expected one result per object, but `versions: true` returns one entry per object version.
   
   This was exposed by the TOS behavior job because TOS now enables both `list_with_versions` and `list_with_start_after` without overriding versioning in CI.
   
   # What changes are included in this PR?
   
   - Map listed entries to `entry.path()` before comparing.
   - Expect two entries for each object written twice.
   - Apply the same assertion fix to async and sync Node.js list option tests.
   
   # Are there any user-facing changes?
   
   No. This only fixes Node.js binding behavior test expectations.
   
   # AI Usage Statement
   
   Used OpenAI Codex to investigate the CI failure and prepare this patch.
   
   Validation:
   
   - `OPENDAL_TEST=tos cargo test --test behavior --features services-tos,tests behavior::test_list_with_versions_and_start_after -- --test-threads=1 --show-output`
   - `OPENDAL_TEST=tos pnpm test -- tests/service.test.mjs -t "list with versions and start after" --testTimeout=600000 --hookTimeout=600000`
   - `pnpm exec prettier --check tests/suites/asyncListOptions.suite.mjs tests/suites/syncListOptions.suite.mjs`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(bindings/nodejs): Align versioned list startAfter test [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7579:
URL: https://github.com/apache/opendal/pull/7579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org