You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Guillaume Smet (JIRA)" <ji...@apache.org> on 2011/01/09 11:35:47 UTC

[jira] Updated: (WICKET-3315) PackagedTextTemplate should set lastModifiedTime

     [ https://issues.apache.org/jira/browse/WICKET-3315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Smet updated WICKET-3315:
-----------------------------------

    Attachment: WICKET-3315.patch

> PackagedTextTemplate should set lastModifiedTime
> ------------------------------------------------
>
>                 Key: WICKET-3315
>                 URL: https://issues.apache.org/jira/browse/WICKET-3315
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.15
>            Reporter: Guillaume Smet
>            Priority: Minor
>         Attachments: WICKET-3315.patch
>
>
> Hi,
> When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.
> IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.
> AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.
> Any comment?
> -- 
> Guillaume

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.