[GitHub] [phoenix] kadirozde commented on a change in pull request #591: PHOENIX-5503 IndexTool does not rebuild all the rows

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #591: PHOENIX-5503 IndexTool does not rebuild all the rows
URL: https://github.com/apache/phoenix/pull/591#discussion_r330182534
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
 ##########
 @@ -312,7 +312,10 @@ public Job getJob() throws Exception {
                     return configureJobForAysncIndex();
                 }
                 else {
-                    //Local and non-transactional global indexes to be built on the server side
+                    // Local and non-transactional global indexes to be built on the server side
+                    // It is safe to unset CURRENT_SCN_VALUE for server side rebuilds to make sure that
+                    // all the rows that has been inserted so far will be rebuilt
+                    configuration.unset(PhoenixConfigurationUtil.CURRENT_SCN_VALUE);
 
 Review comment:
   Instead of moving this to configureJobForServerBuildIndex(), I restructured the code in this method to convince you that this is the right place to set or not to set SCN. Also, please consider that we may want to introduce the SCN option in future. In that case, it should be handled here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services