You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mo...@apache.org on 2009/05/15 14:05:06 UTC
svn commit: r775096 -
/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Author: mor
Date: Fri May 15 12:05:05 2009
New Revision: 775096
URL: http://svn.apache.org/viewvc?rev=775096&view=rev
Log:
Set dafault value of 'Requirement Method Enum Id' drop down. This would not cause any harm.
Patch from Arun Patidar, OFBIZ-2476 (https://issues.apache.org/jira/browse/OFBIZ-2476)
Modified:
ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Modified: ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml?rev=775096&r1=775095&r2=775096&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml (original)
+++ ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml Fri May 15 12:05:05 2009
@@ -124,7 +124,7 @@
<drop-down allow-empty="true" no-current-selected-key="Y"><option key="Y" description="${uiLabelMap.CommonY}"/><option key="N" description="${uiLabelMap.CommonN}"/></drop-down>
</field>
<field name="requirementMethodEnumId">
- <drop-down allow-empty="true">
+ <drop-down allow-empty="true" no-current-selected-key="PRODRQM_ATP">
<entity-options entity-name="Enumeration" key-field-name="enumId" description="${description}">
<entity-constraint name="enumTypeId" value="PROD_REQ_METHOD"/>
<entity-order-by field-name="sequenceId"/>
Re: svn commit: r775096 - /ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Posted by Vikas Mayur <vi...@hotwaxmedia.com>.
Hi David, It makes a lot of sense to me now. Thanks for the details
and indeed this is much better approach. Reverted in revision 775144.
Vikas
On May 15, 2009, at 7:15 PM, David E Jones wrote:
>
> Thanks Vikas. Why not just put the setting in your client's ext
> data? Usually configurable settings like this are set once and then
> stay there until a new requirement comes up, so no UI or code
> changes are needed... just data specific to the client in the
> database.
>
> -David
>
>
> On May 15, 2009, at 7:39 AM, Vikas Mayur wrote:
>
>> I did not think far ahead and does not evaluated which option is
>> better than others or no value. Certainly options are kept default
>> with probably two reasons - widely used and often used.
>>
>> It was just on purpose with a client requirement. I thought that
>> doing this will not do any harm but still if their is any harm I
>> will revert it and will keep a custom patch for it.
>>
>> Vikas
>>
>> On May 15, 2009, at 6:02 PM, David E Jones wrote:
>>
>>>
>>> Why is this option better than others as the default? Going a
>>> little further, why would any default value be better than no
>>> value (ie so requirements are not automatically created)?
>>>
>>> -David
>>>
>>>
>>> On May 15, 2009, at 6:05 AM, mor@apache.org wrote:
>>>
>>>> Author: mor
>>>> Date: Fri May 15 12:05:05 2009
>>>> New Revision: 775096
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=775096&view=rev
>>>> Log:
>>>> Set dafault value of 'Requirement Method Enum Id' drop down. This
>>>> would not cause any harm.
>>>> Patch from Arun Patidar, OFBIZ-2476 (https://issues.apache.org/jira/browse/OFBIZ-2476
>>>> )
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/product/webapp/catalog/store/
>>>> ProductStoreForms.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/product/webapp/catalog/store/
>>>> ProductStoreForms.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml?rev=775096&r1=775095&r2=775096&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/product/webapp/catalog/store/
>>>> ProductStoreForms.xml (original)
>>>> +++ ofbiz/trunk/applications/product/webapp/catalog/store/
>>>> ProductStoreForms.xml Fri May 15 12:05:05 2009
>>>> @@ -124,7 +124,7 @@
>>>> <drop-down allow-empty="true" no-current-selected-
>>>> key="Y"><option key="Y" description="${uiLabelMap.CommonY}"/
>>>> ><option key="N" description="${uiLabelMap.CommonN}"/></drop-down>
>>>> </field>
>>>> <field name="requirementMethodEnumId">
>>>> - <drop-down allow-empty="true">
>>>> + <drop-down allow-empty="true" no-current-selected-
>>>> key="PRODRQM_ATP">
>>>> <entity-options entity-name="Enumeration" key-field-
>>>> name="enumId" description="${description}">
>>>> <entity-constraint name="enumTypeId"
>>>> value="PROD_REQ_METHOD"/>
>>>> <entity-order-by field-name="sequenceId"/>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r775096 - /ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Posted by David E Jones <da...@hotwaxmedia.com>.
Thanks Vikas. Why not just put the setting in your client's ext data?
Usually configurable settings like this are set once and then stay
there until a new requirement comes up, so no UI or code changes are
needed... just data specific to the client in the database.
-David
On May 15, 2009, at 7:39 AM, Vikas Mayur wrote:
> I did not think far ahead and does not evaluated which option is
> better than others or no value. Certainly options are kept default
> with probably two reasons - widely used and often used.
>
> It was just on purpose with a client requirement. I thought that
> doing this will not do any harm but still if their is any harm I
> will revert it and will keep a custom patch for it.
>
> Vikas
>
> On May 15, 2009, at 6:02 PM, David E Jones wrote:
>
>>
>> Why is this option better than others as the default? Going a
>> little further, why would any default value be better than no value
>> (ie so requirements are not automatically created)?
>>
>> -David
>>
>>
>> On May 15, 2009, at 6:05 AM, mor@apache.org wrote:
>>
>>> Author: mor
>>> Date: Fri May 15 12:05:05 2009
>>> New Revision: 775096
>>>
>>> URL: http://svn.apache.org/viewvc?rev=775096&view=rev
>>> Log:
>>> Set dafault value of 'Requirement Method Enum Id' drop down. This
>>> would not cause any harm.
>>> Patch from Arun Patidar, OFBIZ-2476 (https://issues.apache.org/jira/browse/OFBIZ-2476
>>> )
>>>
>>> Modified:
>>> ofbiz/trunk/applications/product/webapp/catalog/store/
>>> ProductStoreForms.xml
>>>
>>> Modified: ofbiz/trunk/applications/product/webapp/catalog/store/
>>> ProductStoreForms.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml?rev=775096&r1=775095&r2=775096&view=diff
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> --- ofbiz/trunk/applications/product/webapp/catalog/store/
>>> ProductStoreForms.xml (original)
>>> +++ ofbiz/trunk/applications/product/webapp/catalog/store/
>>> ProductStoreForms.xml Fri May 15 12:05:05 2009
>>> @@ -124,7 +124,7 @@
>>> <drop-down allow-empty="true" no-current-selected-
>>> key="Y"><option key="Y" description="${uiLabelMap.CommonY}"/
>>> ><option key="N" description="${uiLabelMap.CommonN}"/></drop-down>
>>> </field>
>>> <field name="requirementMethodEnumId">
>>> - <drop-down allow-empty="true">
>>> + <drop-down allow-empty="true" no-current-selected-
>>> key="PRODRQM_ATP">
>>> <entity-options entity-name="Enumeration" key-field-
>>> name="enumId" description="${description}">
>>> <entity-constraint name="enumTypeId"
>>> value="PROD_REQ_METHOD"/>
>>> <entity-order-by field-name="sequenceId"/>
>>>
>>>
>>
>
Re: svn commit: r775096 - /ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Posted by Vikas Mayur <vi...@hotwaxmedia.com>.
I did not think far ahead and does not evaluated which option is
better than others or no value. Certainly options are kept default
with probably two reasons - widely used and often used.
It was just on purpose with a client requirement. I thought that doing
this will not do any harm but still if their is any harm I will revert
it and will keep a custom patch for it.
Vikas
On May 15, 2009, at 6:02 PM, David E Jones wrote:
>
> Why is this option better than others as the default? Going a little
> further, why would any default value be better than no value (ie so
> requirements are not automatically created)?
>
> -David
>
>
> On May 15, 2009, at 6:05 AM, mor@apache.org wrote:
>
>> Author: mor
>> Date: Fri May 15 12:05:05 2009
>> New Revision: 775096
>>
>> URL: http://svn.apache.org/viewvc?rev=775096&view=rev
>> Log:
>> Set dafault value of 'Requirement Method Enum Id' drop down. This
>> would not cause any harm.
>> Patch from Arun Patidar, OFBIZ-2476 (https://issues.apache.org/jira/browse/OFBIZ-2476
>> )
>>
>> Modified:
>> ofbiz/trunk/applications/product/webapp/catalog/store/
>> ProductStoreForms.xml
>>
>> Modified: ofbiz/trunk/applications/product/webapp/catalog/store/
>> ProductStoreForms.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml?rev=775096&r1=775095&r2=775096&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/product/webapp/catalog/store/
>> ProductStoreForms.xml (original)
>> +++ ofbiz/trunk/applications/product/webapp/catalog/store/
>> ProductStoreForms.xml Fri May 15 12:05:05 2009
>> @@ -124,7 +124,7 @@
>> <drop-down allow-empty="true" no-current-selected-
>> key="Y"><option key="Y" description="${uiLabelMap.CommonY}"/
>> ><option key="N" description="${uiLabelMap.CommonN}"/></drop-down>
>> </field>
>> <field name="requirementMethodEnumId">
>> - <drop-down allow-empty="true">
>> + <drop-down allow-empty="true" no-current-selected-
>> key="PRODRQM_ATP">
>> <entity-options entity-name="Enumeration" key-field-
>> name="enumId" description="${description}">
>> <entity-constraint name="enumTypeId"
>> value="PROD_REQ_METHOD"/>
>> <entity-order-by field-name="sequenceId"/>
>>
>>
>
Re: svn commit: r775096 -
/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml
Posted by David E Jones <de...@me.com>.
Why is this option better than others as the default? Going a little
further, why would any default value be better than no value (ie so
requirements are not automatically created)?
-David
On May 15, 2009, at 6:05 AM, mor@apache.org wrote:
> Author: mor
> Date: Fri May 15 12:05:05 2009
> New Revision: 775096
>
> URL: http://svn.apache.org/viewvc?rev=775096&view=rev
> Log:
> Set dafault value of 'Requirement Method Enum Id' drop down. This
> would not cause any harm.
> Patch from Arun Patidar, OFBIZ-2476 (https://issues.apache.org/jira/browse/OFBIZ-2476
> )
>
> Modified:
> ofbiz/trunk/applications/product/webapp/catalog/store/
> ProductStoreForms.xml
>
> Modified: ofbiz/trunk/applications/product/webapp/catalog/store/
> ProductStoreForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/store/ProductStoreForms.xml?rev=775096&r1=775095&r2=775096&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/product/webapp/catalog/store/
> ProductStoreForms.xml (original)
> +++ ofbiz/trunk/applications/product/webapp/catalog/store/
> ProductStoreForms.xml Fri May 15 12:05:05 2009
> @@ -124,7 +124,7 @@
> <drop-down allow-empty="true" no-current-selected-
> key="Y"><option key="Y" description="${uiLabelMap.CommonY}"/><option
> key="N" description="${uiLabelMap.CommonN}"/></drop-down>
> </field>
> <field name="requirementMethodEnumId">
> - <drop-down allow-empty="true">
> + <drop-down allow-empty="true" no-current-selected-
> key="PRODRQM_ATP">
> <entity-options entity-name="Enumeration" key-field-
> name="enumId" description="${description}">
> <entity-constraint name="enumTypeId"
> value="PROD_REQ_METHOD"/>
> <entity-order-by field-name="sequenceId"/>
>
>