You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2020/09/06 21:56:23 UTC

[Issue 128403] New: Mixing of perl backticks and system() in main/set_soenv.in

https://bz.apache.org/ooo/show_bug.cgi?id=128403

          Issue ID: 128403
        Issue Type: DEFECT
           Summary: Mixing of perl backticks and system() in
                    main/set_soenv.in
           Product: Build Tools
           Version: 4.2.0-dev
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P5 (lowest)
         Component: solenv
          Assignee: issues@openoffice.apache.org
          Reporter: vorobyov.mikhail@gmail.com
  Target Milestone: ---

Shouldn't only one of those be used here?

--- a/main/set_soenv.in
+++ b/main/set_soenv.in
@@ -2224,8 +2224,8 @@ print OUT "#!/bin/sh\n";
 if ( $MINGW eq "yes" )
 {  print OUT 'PATH="/usr/bin:$PATH" : export PATH'."\n"; }
 close( OUT ) || print "Can't close $bootfile: $!";
-system(`cat bootstrap.1 >> bootstrap`);
-system(`chmod +x bootstrap`);
+system('cat bootstrap.1 >> bootstrap');
+system('chmod +x bootstrap');
 #
 #--------------------------------------------------------
 # Moving the bootstrap file to the build home directory.

-- 
You are receiving this mail because:
You are the assignee for the issue.

Re: [Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by Matthias Seidel <ma...@hamburg.de>.
Hi Jim,

Am 24.11.20 um 21:19 schrieb Jim Jagielski:
> I've gone ahead and fixed, so if someone wants to login and close this BZ that would be great
Thanks for that, I will do!
>
> PS: I've tried and it's not accepting my ASF LDAP creds.
I think when it was ldap enabled and a separate account existed it had
to be synchronized by Infra...
>
>> On Nov 24, 2020, at 3:14 PM, Matthias Seidel <ma...@hamburg.de> wrote:
>>
>> Hi Jim,
>>
>> Am 24.11.20 um 21:12 schrieb Jim Jagielski:
>>> Actually, it looks like a valid bug and a valid fix.
>>>
>>> Is AOO BZ connected to the ASF's ldap? I can't recall my login
>> I think it is ldap enabled...
>>>> On Nov 24, 2020, at 2:56 PM, Matthias Seidel <ma...@hamburg.de> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Can someone please have a look at this issue?
>>>>
>>>> I don't like the idea of having a ticket closed only because someone does not understand it...
>>>>
>>>> Regards,
>>>>
>>>>   Matthias
>>>>
>>>>
>>>>
>>>> -------- Weitergeleitete Nachricht --------
>>>> Betreff:	[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in
>>>> Datum:	Tue, 24 Nov 2020 19:29:21 +0000
>>>> Von:	bugzilla@apache.org <ma...@apache.org> <mailto:bugzilla@apache.org <ma...@apache.org>>
>>>> Antwort an:	issues@openoffice.apache.org <ma...@openoffice.apache.org> <mailto:issues@openoffice.apache.org <ma...@openoffice.apache.org>>
>>>> An:	issues@openoffice.apache.org <ma...@openoffice.apache.org> <mailto:issues@openoffice.apache.org <ma...@openoffice.apache.org>>
>>>>
>>>> https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403> <https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403>>
>>>>
>>>> oooforum (fr) <oooforum@free.fr <ma...@free.fr>> <mailto:oooforum@free.fr <ma...@free.fr>> changed:
>>>>
>>>> What |Removed |Added
>>>> ----------------------------------------------------------------------------
>>>> Resolution|--- |NOT_AN_OOO_ISSUE
>>>> Status|UNCONFIRMED |RESOLVED
>>>> CC| |oooforum@free.fr <ma...@free.fr> <mailto:oooforum@free.fr <ma...@free.fr>>
>>>>
>>>> --- Comment #1 from oooforum (fr) <oooforum@free.fr <ma...@free.fr>> <mailto:oooforum@free.fr <ma...@free.fr>> ---
>>>> Sorry, I don't understand what you means.
>>>> Could be more explicite?
>>>>
>>>> Set temporarily as "not an issue".
>>>>
>>>> -- 
>>>> You are receiving this mail because:
>>>> You are the assignee for the issue.
>


Re: [Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by Jim Jagielski <ji...@jaguNET.com>.
I've gone ahead and fixed, so if someone wants to login and close this BZ that would be great

PS: I've tried and it's not accepting my ASF LDAP creds.

> On Nov 24, 2020, at 3:14 PM, Matthias Seidel <ma...@hamburg.de> wrote:
> 
> Hi Jim,
> 
> Am 24.11.20 um 21:12 schrieb Jim Jagielski:
>> Actually, it looks like a valid bug and a valid fix.
>> 
>> Is AOO BZ connected to the ASF's ldap? I can't recall my login
> I think it is ldap enabled...
>> 
>>> On Nov 24, 2020, at 2:56 PM, Matthias Seidel <ma...@hamburg.de> wrote:
>>> 
>>> Hi all,
>>> 
>>> Can someone please have a look at this issue?
>>> 
>>> I don't like the idea of having a ticket closed only because someone does not understand it...
>>> 
>>> Regards,
>>> 
>>>   Matthias
>>> 
>>> 
>>> 
>>> -------- Weitergeleitete Nachricht --------
>>> Betreff:	[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in
>>> Datum:	Tue, 24 Nov 2020 19:29:21 +0000
>>> Von:	bugzilla@apache.org <ma...@apache.org> <mailto:bugzilla@apache.org <ma...@apache.org>>
>>> Antwort an:	issues@openoffice.apache.org <ma...@openoffice.apache.org> <mailto:issues@openoffice.apache.org <ma...@openoffice.apache.org>>
>>> An:	issues@openoffice.apache.org <ma...@openoffice.apache.org> <mailto:issues@openoffice.apache.org <ma...@openoffice.apache.org>>
>>> 
>>> https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403> <https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403>>
>>> 
>>> oooforum (fr) <oooforum@free.fr <ma...@free.fr>> <mailto:oooforum@free.fr <ma...@free.fr>> changed:
>>> 
>>> What |Removed |Added
>>> ----------------------------------------------------------------------------
>>> Resolution|--- |NOT_AN_OOO_ISSUE
>>> Status|UNCONFIRMED |RESOLVED
>>> CC| |oooforum@free.fr <ma...@free.fr> <mailto:oooforum@free.fr <ma...@free.fr>>
>>> 
>>> --- Comment #1 from oooforum (fr) <oooforum@free.fr <ma...@free.fr>> <mailto:oooforum@free.fr <ma...@free.fr>> ---
>>> Sorry, I don't understand what you means.
>>> Could be more explicite?
>>> 
>>> Set temporarily as "not an issue".
>>> 
>>> -- 
>>> You are receiving this mail because:
>>> You are the assignee for the issue.


Re: [Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by Matthias Seidel <ma...@hamburg.de>.
Hi Jim,

Am 24.11.20 um 21:12 schrieb Jim Jagielski:
> Actually, it looks like a valid bug and a valid fix.
>
> Is AOO BZ connected to the ASF's ldap? I can't recall my login
I think it is ldap enabled...
>
>> On Nov 24, 2020, at 2:56 PM, Matthias Seidel <ma...@hamburg.de> wrote:
>>
>> Hi all,
>>
>> Can someone please have a look at this issue?
>>
>> I don't like the idea of having a ticket closed only because someone does not understand it...
>>
>> Regards,
>>
>>    Matthias
>>
>>
>>
>> -------- Weitergeleitete Nachricht --------
>> Betreff:	[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in
>> Datum:	Tue, 24 Nov 2020 19:29:21 +0000
>> Von:	bugzilla@apache.org <ma...@apache.org>
>> Antwort an:	issues@openoffice.apache.org <ma...@openoffice.apache.org>
>> An:	issues@openoffice.apache.org <ma...@openoffice.apache.org>
>>
>> https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403>
>>
>> oooforum (fr) <oo...@free.fr> <ma...@free.fr> changed:
>>
>> What |Removed |Added
>> ----------------------------------------------------------------------------
>> Resolution|--- |NOT_AN_OOO_ISSUE
>> Status|UNCONFIRMED |RESOLVED
>> CC| |oooforum@free.fr <ma...@free.fr>
>>
>> --- Comment #1 from oooforum (fr) <oo...@free.fr> <ma...@free.fr> ---
>> Sorry, I don't understand what you means.
>> Could be more explicite?
>>
>> Set temporarily as "not an issue".
>>
>> -- 
>> You are receiving this mail because:
>> You are the assignee for the issue.
>


Re: [Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by Jim Jagielski <ji...@jaguNET.com>.
Actually, it looks like a valid bug and a valid fix.

Is AOO BZ connected to the ASF's ldap? I can't recall my login

> On Nov 24, 2020, at 2:56 PM, Matthias Seidel <ma...@hamburg.de> wrote:
> 
> Hi all,
> 
> Can someone please have a look at this issue?
> 
> I don't like the idea of having a ticket closed only because someone does not understand it...
> 
> Regards,
> 
>    Matthias
> 
> 
> 
> -------- Weitergeleitete Nachricht --------
> Betreff:	[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in
> Datum:	Tue, 24 Nov 2020 19:29:21 +0000
> Von:	bugzilla@apache.org <ma...@apache.org>
> Antwort an:	issues@openoffice.apache.org <ma...@openoffice.apache.org>
> An:	issues@openoffice.apache.org <ma...@openoffice.apache.org>
> 
> https://bz.apache.org/ooo/show_bug.cgi?id=128403 <https://bz.apache.org/ooo/show_bug.cgi?id=128403>
> 
> oooforum (fr) <oo...@free.fr> <ma...@free.fr> changed:
> 
> What |Removed |Added
> ----------------------------------------------------------------------------
> Resolution|--- |NOT_AN_OOO_ISSUE
> Status|UNCONFIRMED |RESOLVED
> CC| |oooforum@free.fr <ma...@free.fr>
> 
> --- Comment #1 from oooforum (fr) <oo...@free.fr> <ma...@free.fr> ---
> Sorry, I don't understand what you means.
> Could be more explicite?
> 
> Set temporarily as "not an issue".
> 
> -- 
> You are receiving this mail because:
> You are the assignee for the issue.


Fwd: [Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by Matthias Seidel <ma...@hamburg.de>.
Hi all,

Can someone please have a look at this issue?

I don't like the idea of having a ticket closed only because someone
does not understand it...

Regards,

   Matthias



-------- Weitergeleitete Nachricht --------
Betreff: 	[Issue 128403] Mixing of perl backticks and system() in
main/set_soenv.in
Datum: 	Tue, 24 Nov 2020 19:29:21 +0000
Von: 	bugzilla@apache.org
Antwort an: 	issues@openoffice.apache.org
An: 	issues@openoffice.apache.org



https://bz.apache.org/ooo/show_bug.cgi?id=128403

oooforum (fr) <oo...@free.fr> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |NOT_AN_OOO_ISSUE
Status|UNCONFIRMED |RESOLVED
CC| |oooforum@free.fr

--- Comment #1 from oooforum (fr) <oo...@free.fr> ---
Sorry, I don't understand what you means.
Could be more explicite?

Set temporarily as "not an issue".

-- 
You are receiving this mail because:
You are the assignee for the issue.


[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128403

oooforum (fr) <oo...@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOT_AN_OOO_ISSUE
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |oooforum@free.fr

--- Comment #1 from oooforum (fr) <oo...@free.fr> ---
Sorry, I don't understand what you means.
Could be more explicite?

Set temporarily as "not an issue".

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128403

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOT_AN_OOO_ISSUE            |FIXED

--- Comment #2 from Matthias Seidel <ms...@apache.org> ---
Fixed in trunk with:
https://github.com/apache/openoffice/commit/6dee92fc114c8598a192b75a4a8146b6fcd238cd

Cherry-picked for AOO42X with:
https://github.com/apache/openoffice/commit/11e298eca1e00752c6a010762580ba3dffbe873b

Thank you for finding this!

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128403

Matthias Seidel <ms...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mseidel@apache.org

-- 
You are receiving this mail because:
You are the assignee for the issue.

[Issue 128403] Mixing of perl backticks and system() in main/set_soenv.in

Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128403

Marcus <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.2.0

--- Comment #3 from Marcus <ma...@apache.org> ---
I've set "4.2.0" as target milestone.

-- 
You are receiving this mail because:
You are the assignee for the issue.