You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/07/31 19:07:03 UTC

Review Request 61263: ATLAS-2010: Hook consumer should start consumption after type registry init is complete

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61263/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-2010
    https://issues.apache.org/jira/browse/ATLAS-2010


Repository: atlas


Description
-------

Sometimes the Hook consumer bean gets created before the type registry has been fully initialized and when it's trying to create the entity, the type name is missing from the registry.
Add depends on the HookConsumer class to make sure that the creation only happens after type registry is completely bootstrapped.


Diffs
-----

  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java e35fb33f 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java b8255b36 


Diff: https://reviews.apache.org/r/61263/diff/1/


Testing
-------

mvn clean package executes successfully

Atlas server startup was successful and basic operations were good, no anomaly.


Thanks,

Apoorv Naik


Re: Review Request 61263: ATLAS-2010: Hook consumer should start consumption after type registry init is complete

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61263/#review182038
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On July 31, 2017, 7:07 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61263/
> -----------------------------------------------------------
> 
> (Updated July 31, 2017, 7:07 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2010
>     https://issues.apache.org/jira/browse/ATLAS-2010
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Sometimes the Hook consumer bean gets created before the type registry has been fully initialized and when it's trying to create the entity, the type name is missing from the registry.
> Add depends on the HookConsumer class to make sure that the creation only happens after type registry is completely bootstrapped.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java e35fb33f 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java b8255b36 
> 
> 
> Diff: https://reviews.apache.org/r/61263/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully
> 
> Atlas server startup was successful and basic operations were good, no anomaly.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>