You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/23 12:33:00 UTC
[GitHub] [superset] kaapstorm opened a new pull request #19331: docs: fix: Use three backticks for code blocks
kaapstorm opened a new pull request #19331:
URL: https://github.com/apache/superset/pull/19331
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Fixes a tiny issue in **CONTRIBUTING.md**: A code block was opened with four backticks, attempted to be closed with three backticks, and then a second code block was opened with three backticks and closed with four. The result was that the three backticks appeared inside the code block as code, along with a line of plain text.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**BEFORE**
**AFTER**
### TESTING INSTRUCTIONS
Rendered Markdown locally.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes https://github.com/apache/superset/issues/19330
- [x] Has associated issue: #19330
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #19331: docs: fix: Use three backticks for code blocks
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #19331:
URL: https://github.com/apache/superset/pull/19331#issuecomment-1076385966
Thanks for the catch & fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi merged pull request #19331: docs: fix: Use three backticks for code blocks
Posted by GitBox <gi...@apache.org>.
AAfghahi merged pull request #19331:
URL: https://github.com/apache/superset/pull/19331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org