[GitHub] [lucene-solr] diegoceccarelli edited a comment on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

[GitBox <gi...@apache.org>]

diegoceccarelli edited a comment on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-535627929
 
 
   Hi @cpoerschke! I think I addressed your comments, please let me know if I missed anything! 
   
   Overview of the changes:
   - I found an explanation for the mystery of the two test failing and I fixed them.
   - Added checks for `numFound == 1`
   - Improved documentation 
   - Forbid `group.func` and `group.query` and documented it. 
   - Fix issues with `maxScore`, added tests. 
   
   I have fixed some issues with distribute `maxScore` that are not related to the patch but I needed to fix for tests and I think I'm going to move them into a separate PR (edit: I opened PR https://github.com/apache/lucene-solr/pull/906 for that `maxScore` change).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org