You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/22 19:47:27 UTC
[GitHub] [pulsar] srkukarni opened a new pull request #6798: Sanitize Perm Checks
srkukarni opened a new pull request #6798:
URL: https://github.com/apache/pulsar/pull/6798
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
Tenant admin has the ability to produce/consume. This is honored by the http api, but not the binary api.
This pr brings consistency to this.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on issue #6798: Sanitize Perm Checks
Posted by GitBox <gi...@apache.org>.
srkukarni commented on issue #6798:
URL: https://github.com/apache/pulsar/pull/6798#issuecomment-618176632
@jiazhai The superUser check happens in AuthorizationService so that is not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #6798: Sanitize Perm Checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6798:
URL: https://github.com/apache/pulsar/pull/6798#issuecomment-1058899716
@srkukarni:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on issue #6798: Sanitize Perm Checks
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6798:
URL: https://github.com/apache/pulsar/pull/6798#issuecomment-618200536
> Tenant admin has the ability to produce/consume. This is honored by the http api, but not the binary api.
I am confused by this statement. Http doesn't provide any ability to produce and consume messages. You have to grant a role permissions to produce and consume messages using HTTP admin API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on issue #6798: Sanitize Perm Checks
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6798:
URL: https://github.com/apache/pulsar/pull/6798#issuecomment-618165197
@srkukarni Is the superuser role has the same issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #6798: Sanitize Perm Checks
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #6798:
URL: https://github.com/apache/pulsar/pull/6798#discussion_r413535462
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -935,6 +937,38 @@ private SchemaData getSchema(PulsarApi.Schema protocolSchema) {
)).build();
}
+ private CompletableFuture<Boolean> canProduce(TopicName topicName, String role) {
+ return computeAuthorizedFuture(topicName, role, null, true);
+ }
+
+ private CompletableFuture<Boolean> canConsume(TopicName topicName, String role, String subscription) {
+ return computeAuthorizedFuture(topicName, role, subscription, false);
+ }
+
+ private CompletableFuture<Boolean> computeAuthorizedFuture(TopicName topicName, String role, String subscription, boolean produce) {
+ String path = PulsarWebResource.path(ConfigurationCacheService.POLICIES, topicName.getTenant());
+ try {
+ TenantInfo tenantInfo = service.getPulsar().getConfigurationCache().propertiesCache().get(path)
+ .orElseThrow(() -> new PulsarServerException.NotFoundException("Tenant does not exist"));
+ CompletableFuture<Boolean> isTenantAdminFuture = service.getAuthorizationService().isTenantAdmin(topicName.getTenant(), role, tenantInfo, authenticationData);
+ return isTenantAdminFuture.thenCompose(isTenantAdmin -> {
+ if (isTenantAdmin) { return CompletableFuture.completedFuture(true); }
Review comment:
what is the motivation of this change? This seems to change the behavior of the current authorization system. It allows tenant admin to produce and consume messages. In general, this is a breaking change. There is also an attempt to change the authorization system in PIP-49. It was pushed back. We shouldn't change the existing authorization system. If you want to allow TenantAdmin to produce and consume messages, you should implement a new AuthorizationProvider.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org