You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/14 17:59:11 UTC
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3529: Minor: Add documentation about memory use for ArrayData
viirya commented on code in PR #3529:
URL: https://github.com/apache/arrow-rs/pull/3529#discussion_r1070362453
##########
arrow-data/src/bitmap.rs:
##########
@@ -68,12 +68,23 @@ impl Bitmap {
self.bits
}
- /// Returns the total number of bytes of memory occupied by the buffers owned by this [Bitmap].
+ /// Returns the total number of bytes of memory occupied by the
+ /// buffers owned by this [Bitmap].
+ ///
+ /// Note that this [`Bitmap`] may only refer to a subset of the
+ /// data in the underlying [`Buffer`], but the size includes the
+ /// entire size of the buffer.
Review Comment:
I think this sentence basically tells that this Bitmap is a slice of the Buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org