[GitHub] [beam] ihji commented on a change in pull request #15429: Add per-batch metrics to JdbcIO.write

[GitBox <gi...@apache.org>]

ihji commented on a change in pull request #15429:
URL: https://github.com/apache/beam/pull/15429#discussion_r699626924



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1694,6 +1700,7 @@ private void executeBatch() throws SQLException, IOException, InterruptedExcepti
         if (records.isEmpty()) {
           return;
         }
+        Long startTimeNs = System.nanoTime();

Review comment:
       Any reason to choose `System.nanoTime()` vs `System.currentTimeMillis()`?

##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1694,6 +1700,7 @@ private void executeBatch() throws SQLException, IOException, InterruptedExcepti
         if (records.isEmpty()) {
           return;
         }
+        Long startTimeNs = System.nanoTime();

Review comment:
       Thanks, LGTM.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org