You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/01 00:03:14 UTC

[GitHub] [beam] boyuanzz commented on pull request #12930: [BEAM-10962] Add Multiple PubSub reader to Python SDK

boyuanzz commented on pull request #12930:
URL: https://github.com/apache/beam/pull/12930#issuecomment-701708484


   Expect what Cham has mentioned, another thing is current implementation of `MultipleReadFromPubSub` only can configure multiple `ReadFromPubSub` with the same attribute, like the same `with_attributes`, `timestamp_label`, `id_label`, which is not ideal. Given that `ReadPubSub` is a native transform for Dataflow, having `MultipleReadFromPubSub` seems like the only solution for now. I'm thinking we could create a `PubSubSourceDescriptor` which includes `topic`, `subscription` and other attributes. And we expose `add` API from `MultipleReadFromPubSub` to allow end users to add a new Read.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org