You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Freeman Fang (Created) (JIRA)" <ji...@apache.org> on 2012/03/02 09:52:01 UTC

[jira] [Created] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

blueprint deployer and spring deployer should get started before features.core bundle
-------------------------------------------------------------------------------------

                 Key: KARAF-1245
                 URL: https://issues.apache.org/jira/browse/KARAF-1245
             Project: Karaf
          Issue Type: Improvement
            Reporter: Freeman Fang
            Assignee: Freeman Fang


When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
<bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461642#comment-13461642 ] 

Ioannis Canellos commented on KARAF-1245:
-----------------------------------------

I think that using a service tracker to wait for the handler does solve the problem (the way it works now).
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Ioannis Canellos
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jean-Baptiste Onofré (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré updated KARAF-1245:
----------------------------------------

    Fix Version/s: 3.0.0
    
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Work started] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Freeman Fang (Work started) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on KARAF-1245 started by Freeman Fang.

> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225940#comment-13225940 ] 

Jean-Baptiste Onofré commented on KARAF-1245:
---------------------------------------------

Nevermind, the deployers should be in the startup.properties, else the features.core will always be started before.

I move the deployers into the startup.properties.
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jean-Baptiste Onofré (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225938#comment-13225938 ] 

Jean-Baptiste Onofré commented on KARAF-1245:
---------------------------------------------

Even if the blueprint and spring deployers are not in the startup.properties, they are started after the features core on trunk:

karaf@root> la|grep -i deployer
[  43] [Active     ] [Created     ] [   30] Apache Karaf :: Deployer :: Blueprint (3.0.0.SNAPSHOT)
[  44] [Active     ] [Created     ] [   30] Apache Karaf :: Deployer :: Features (3.0.0.SNAPSHOT)
[  45] [Active     ] [Created     ] [   30] Apache Karaf :: Deployer :: Wrap Non OSGi Jar (3.0.0.SNAPSHOT)
karaf@root> la|grep -i feature
[  20] [Active     ] [Created     ] [   25] Apache Karaf :: Features :: Core (3.0.0.SNAPSHOT)

I don't think it's required to put the deployers in the startup.properties, but we should update the start-level to 24 in order to start them before the features core bundle.

I do it ;)
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Closed] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jamie goodyear closed KARAF-1245.
---------------------------------

    
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461471#comment-13461471 ] 

Christian Schneider commented on KARAF-1245:
--------------------------------------------

I think the feature install now waits for some time for missing url handlers. Does this fix the problem? I am also working on parallelizing the install of bundles. This will help if the url handler appear after a bundle they should install. See kARAf-608. I will explain what I have in mind there shortly.
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Ioannis Canellos
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Freeman Fang (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Freeman Fang resolved KARAF-1245.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.6
    
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Freeman Fang
>             Fix For: 2.2.6
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jean-Baptiste Onofré (Reopened JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré reopened KARAF-1245:
-----------------------------------------

      Assignee: Jean-Baptiste Onofré  (was: Freeman Fang)

Thanks Freeman.

Let me check if we are in the same situation on trunk for Karaf 3.0.0.
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Christian Schneider (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461643#comment-13461643 ] 

Christian Schneider commented on KARAF-1245:
--------------------------------------------

Yes .. but then we depend on the handlers .. I would like to find a solution that can work with unknown handlers too. Basically the idea is to first load bundles that do not need the handlers. We then need to start at least the bundles with the handlers before starting the rest. The problem is that there is no way to see if a bundle contains a handler from the outside. So I am not sure how to achieve it.
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Ioannis Canellos
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Freeman Fang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225914#comment-13225914 ] 

Freeman Fang commented on KARAF-1245:
-------------------------------------

Hi JB,

On Karaf 3.0, the blueprint/spring deployer isn't in startup.properties, they're in deployer feature description, so unless we also pull blueprint/spring deployer bundles into startup.properties, there's no way we can guarantee that they get started before features.core bundle. 
I'm +1 to put blueprint/spring deployer bundles into startup.properties, it's easier for end user when they have features which need blueprint/spring url handler.

Freeman
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Jean-Baptiste Onofré (Resolved JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Onofré resolved KARAF-1245.
-----------------------------------------

    Resolution: Fixed
    
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Reopened] (KARAF-1245) blueprint deployer and spring deployer should get started before features.core bundle

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KARAF-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos reopened KARAF-1245:
-------------------------------------

      Assignee: Ioannis Canellos  (was: Jean-Baptiste Onofré)

I am reopening the issue, because I feel that the features service should not depend on deployers of any short.

Moreover, the current solution may solve the problem for blueprint and spring url handlers, but still doesn't address the case where the user wants to use a custom url handler.
                
> blueprint deployer and spring deployer should get started before features.core bundle
> -------------------------------------------------------------------------------------
>
>                 Key: KARAF-1245
>                 URL: https://issues.apache.org/jira/browse/KARAF-1245
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Freeman Fang
>            Assignee: Ioannis Canellos
>             Fix For: 2.2.6, 3.0.0
>
>
> When org.apache.karaf.features.core bundle is up, it will load features descriptors and try install features, however if the features descriptor has bundle like
> <bundle>blueprint:file:etc/some-blueprint.xml</bundle>, we need blueprint url handler available in the OSGi container, so we need blueprint deployer and spring deployer get started before features.core bundle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira