You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/01 13:12:49 UTC

[GitHub] [rocketmq] Cczzzz opened a new issue #1813: message trace can't record sendResult in async send

Cczzzz opened a new issue #1813: message trace can't record  sendResult in async send 
URL: https://github.com/apache/rocketmq/issues/1813
 
 
   In the call  SendMessageHook,In the asynchronous case , The sending unfinished achievement has been called executeSendMessageHookAfter.in DefaultMQProducerImpl  846 line.
   ```
     if (this.hasSendMessageHook()) {
                       context.setSendResult(sendResult);
                       this.executeSendMessageHookAfter(context);
                   }
   
   ```
   call this hook ,just  complete call sendMessage,Maybe asynchronous hasn't responded yet,so you can`t get  sendResult , It is also called once after a normal successful call   executeSendMessageHookAfter, but if it in exception ,not call executeSendMessageHookAfter.
   And no exceptions were recorded .Would you consider enhancing it
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] ShannonDing commented on issue #1813: message trace can't record sendResult in async send

Posted by GitBox <gi...@apache.org>.

ShannonDing commented on issue #1813: message trace can't record  sendResult in async send 
URL: https://github.com/apache/rocketmq/issues/1813#issuecomment-598056579
 
 
   in the MQClientAPI.java file， on line530, the hook was called again when the feature get response.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] duhenglucky commented on issue #1813: message trace can't record sendResult in async send

Posted by GitBox <gi...@apache.org>.

duhenglucky commented on issue #1813: message trace can't record  sendResult in async send 
URL: https://github.com/apache/rocketmq/issues/1813#issuecomment-598055294
 
 
   @Cczzzz It is better to add a judgment that is sent asynchronously and processed during the execution of callback(org.apache.rocketmq.client.trace.hook.SendMessageTraceHookImpl#sendMessageAfter). Would you like to propose a PR to polish it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services