You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/11/01 07:39:20 UTC
[PR] [#2229] feat(server/client): Introduce OutputUtils class to reduce log size [incubator-uniffle]
maobaolong opened a new pull request, #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong merged PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2459429616
@jerqi Thanks for your review, merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461536251
> If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of illegal different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong
A lot of projects adopt the style `feat(server,client)`, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461410604
@maobaolong Sorry for this mistake, will check it before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2451491947
## Test Results
2 941 files +46 2 941 suites +46 6h 12m 27s ⏱️ + 15m 58s
1 089 tests + 1 1 087 ✅ + 2 2 💤 ±0 0 ❌ ±0
13 645 runs +75 13 615 ✅ +76 30 💤 ±0 0 ❌ ±0
Results for commit 3d20b96e. ± Comparison against base commit 680f96a1.
[test-results]:data:application/gzip;base64,H4sIANiOJGcC/02Myw6DIBBFf8Ww7gIcxNKfaUaBhFSl4bEy/ffiC1meM3PPSoyddCCvppWcPRoSko01q+QxWrdspgXeZ5Xvcftg9CkvfIc0jofrb/ex321XhEE7ZUGL0N47fxqflr0KgncnlioIdrujCtemru5cR0c3zzZmIKBaOkihQdChYwZRGYGGUw1oYGCoEDQqScnvDxSu3acUAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2464189932
> > If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of illegal different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong
>
> A lot of projects adopt the style `feat(server,client)`, too.
It's oK for me. Let's unify this style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2229] feat(server,client): Introduce `OutputUtils` class to reduce log size [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2230:
URL: https://github.com/apache/incubator-uniffle/pull/2230#issuecomment-2461351104
If having multi modules associated change, the style commit log could be unified as the `feat(server)(client)`. I have seen a lot of different styles like `feat(server,client)` and `feat(server/client)` . @maobaolong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org