You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2025/11/11 12:10:32 UTC
[PR] Bugfix/into view [datafusion]
timsaucer opened a new pull request, #18617:
URL: https://github.com/apache/datafusion/pull/18617
## Which issue does this PR close?
https://github.com/apache/datafusion/pull/18158 introduced a regression in the table type created with `DataFrame::into_view()`
## Rationale for this change
Correct regression
## What changes are included in this PR?
One line fix
## Are these changes tested?
Unit test added
## Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: correct regression on TableType for into_view [datafusion]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #18617:
URL: https://github.com/apache/datafusion/pull/18617#issuecomment-3516608481
@r1b mind a quick review? One line change to the code, plus unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: correct regression on TableType for into_view [datafusion]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #18617:
URL: https://github.com/apache/datafusion/pull/18617#discussion_r2514721067
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1627,7 +1627,9 @@ async fn register_table() -> Result<()> {
let df_impl = DataFrame::new(ctx.state(), df.logical_plan().clone());
// register a dataframe as a table
- ctx.register_table("test_table", df_impl.clone().into_view())?;
+ let table_provider = df_impl.clone().into_view();
+ assert_eq!(table_provider.table_type(), TableType::View);
+ ctx.register_table("test_table", table_provider)?;
Review Comment:
This `TableType::View` assert is the only one test check for `into_view` and it is in a test that looks like not added particularly for it. That's said it is very possible it will be forgotten easily.
Maybe just add a simple test specific for `into_view`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: correct regression on TableType for into_view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #18617:
URL: https://github.com/apache/datafusion/pull/18617#issuecomment-3518460767
Thanks @timsaucer @viirya and @Jefffrey -- great call to add a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: correct regression on TableType for into_view [datafusion]
Posted by "r1b (via GitHub)" <gi...@apache.org>.
r1b commented on PR #18617:
URL: https://github.com/apache/datafusion/pull/18617#issuecomment-3518941182
Thank you @timsaucer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] bugfix: correct regression on TableType for into_view [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #18617:
URL: https://github.com/apache/datafusion/pull/18617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org