[jira] [Closed] (LEGAL-156) Can we accept pull requests from github ?

["Kristian Rosenvold (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LEGAL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold closed LEGAL-156.
------------------------------------

    Resolution: Fixed

> Can we accept pull requests from github ?
> -----------------------------------------
>
>                 Key: LEGAL-156
>                 URL: https://issues.apache.org/jira/browse/LEGAL-156
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Kristian Rosenvold
>
> In maven, we generally require that all external submissions have JIRA issues. With svn we would normally have patches attached to the jira issue, which would link a submission to the submitter.
> With pull requests coming in from github, we receive a "submission" that is tagged with author name and email and an external reference to the diff (a link to the commit on github). This pull request is sent to ASF mailing lists and would IMO serve as a record of submission. Given that the author information in the commit seems valid, can we accept such a pull request directly ? (to this moment we still require that authors add patches to jira as well)
> (It would look to me like the only thing missing is that we have the process picking up the pull requests actually attach the diff to the mail too, but heck IANAL).



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org