[GitHub] [beam] lostluck commented on pull request #22196: Collect heap dumps on Go worker panic for Dataflow

[GitBox <gi...@apache.org>]

lostluck commented on PR #22196:
URL: https://github.com/apache/beam/pull/22196#issuecomment-1179182567

   I was under the impression that there were panics we couldn't use "recover" from, such as
   OOM and concurrent map writes+reads.  Otherwise, this would be something else we need to bolster our "callNoPanic" path with since an OOM'd worker isn't likely to be able to recover.
   
   See https://stackoverflow.com/questions/57486620/are-all-runtime-errors-recoverable-in-go for some examples on how to trigger them.
   
   It does seem like we could probably have an actual integration test for this too that runs on Dataflow, pipeline that will start, and then OOM, and then we could observe the heap dump was written to the given GCS folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org