You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/04 05:28:04 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4000: vm: Reset deviceId to fix missing nic with vm
ustcweizhou opened a new pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000
## Description
<!--- Describe your changes in detail -->
This PR aims to fix the issue which can be reproduced as below:
1. create a vm with 3 networks
2. remove the 2nd network from the vm
3. stop the vm
4. start the vm
Expected result: vm is started with 2 nics (on 1st network and 3rd network)
Actual result: vm is started with only first nic (on 1st network).
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
With this PR, the vm is started with all nics.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638565421
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653724592
Packaging result: ✖centos7 ✖debian. JID-1519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638593882
Can you check build/Travis failures @ustcweizhou ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653723815
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-665855923
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653723888
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638586311
Packaging result: ✖centos7 ✖debian. JID-1286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-668398530
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-643063586
@ustcweizhou please check and address Travis failures
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-654650349
@ustcweizhou can you review the failures?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-668398016
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-665856688
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638565172
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-668852158
<b>Trillian test result (tid-2255)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56480 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4000-t2255-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.03 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org