You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/09/14 13:19:55 UTC
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/817
Cherry-pick PR #795 into 4.5 branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack 4.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #817
----
commit a54dffc570a6c5c5d0b75bf4ea5abf5e003ccdd9
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-09-09T15:53:35Z
Added QCOW2 virtual size checking for S3.
- Cleaned up S3TemplateDownloader
- Created static QCOW2 utils class.
- Reformatted some parts of DownloadManagerImpl
commit dc670d55bf97504eb3165c46dca708b2bf9d020c
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-09-14T08:56:11Z
Fixed Findbugs issue introduced by 1c6378ec0056e8c75990a4a0c15e99b2df162a75 PR #795.
commit db8abaa6bb7ce56c23f1f8adb89cc8ab4c0d4eb2
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-09-14T11:18:43Z
Added Unit Tests for QCOW2Utils.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-140650340
Also there seems to be a license header issue (missing new line between header and package definition in the utils class).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-141342804
LGTM, merging this this is already merged on master and builds are passing on 4.5 branch now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-140277680
4.5 was missing upgrade path, implemented that; please push again to force a travis build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-140301614
@bhaisaab Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-140777872
@bhaisaab Updated the PR. Tests run fine now. Thanks for your time!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [4.5.3]Cherry-pick PR #795 into 4.5 branc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/817#issuecomment-140648696
@borisroman not sure about the apache repo error, I'm having build failures when building locally due to getPreferredCharset method not avialable in StringUtils class (utils package). Please test locally and update the PR thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---