You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/04/01 13:26:52 UTC

[GitHub] [drill] ihuzenko commented on issue #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

ihuzenko commented on issue #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#issuecomment-478578390
 
 
   Hello @kkhatua, generally the PR looks good, only one comment related to test. And interesting thing with UI is that setting auto limit value to "100 " is prohibited because of space sign after number, should we trim all accepted values ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services