You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/04/20 03:39:06 UTC
[jira] [Commented] (PIG-1978) Secondary sort fail when
dereferencing two fields inside foreach
[ https://issues.apache.org/jira/browse/PIG-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021898#comment-13021898 ]
jiraposter@reviews.apache.org commented on PIG-1978:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/621/#review500
-----------------------------------------------------------
Ship it!
+1
- thejas
On 2011-04-19 00:37:31, Daniel Dai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/621/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-19 00:37:31)
bq.
bq.
bq. Review request for pig and thejas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See PIG-1978
bq.
bq.
bq. This addresses bug PIG-1978.
bq. https://issues.apache.org/jira/browse/PIG-1978
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/SecondaryKeyOptimizer.java 1091982
bq. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestSecondarySort.java 1091982
bq.
bq. Diff: https://reviews.apache.org/r/621/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test-patch:
bq. [exec] +1 @author. The patch does not contain any @author tags.
bq. [exec]
bq. [exec] +1 tests included. The patch appears to include 3 new or modified tests.
bq. [exec]
bq. [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
bq. [exec]
bq. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
bq. [exec]
bq. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
bq. [exec]
bq. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
bq.
bq. Unit test:
bq. all pass
bq.
bq.
bq. Thanks,
bq.
bq. Daniel
bq.
bq.
> Secondary sort fail when dereferencing two fields inside foreach
> ----------------------------------------------------------------
>
> Key: PIG-1978
> URL: https://issues.apache.org/jira/browse/PIG-1978
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-1978-1.patch
>
>
> The following script fail:
> {code}
> a = load '1.txt' as (a0, a1, a2);
> b = group a by (a0, a1);
> c = foreach b {
> c1 = a.(a1,a2);
> generate group, c1;
> }
> explain c;
> {code}
> Error message:
> Caused by: org.apache.pig.impl.logicalLayer.FrontendException: ERROR 0: POForEach has more than 1 input plans
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.SecondaryKeyOptimizer$SecondaryKeyDiscover.processForEach(SecondaryKeyOptimizer.java:551)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.SecondaryKeyOptimizer$SecondaryKeyDiscover.processRoot(SecondaryKeyOptimizer.java:485)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.SecondaryKeyOptimizer$SecondaryKeyDiscover.process(SecondaryKeyOptimizer.java:470)
> at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.SecondaryKeyOptimizer.visitMROp(SecondaryKeyOptimizer.java:254)
> Thanks William reporting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira