You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "himansh295 (via GitHub)" <gi...@apache.org> on 2023/03/05 13:21:17 UTC

[GitHub] [incubator-eventmesh] himansh295 opened a new pull request, #3346: Avoiding Null Pointer Exception on line 113,148

himansh295 opened a new pull request, #3346:
URL: https://github.com/apache/incubator-eventmesh/pull/3346

   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
   
     - Fill out the template below to describe the changes contributed by the pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
   -->
   
   Fixes #<XXXX>.
   
   ### Motivation
   
   *Explain the content here.*
   *Explain why you want to make the changes and what problem you're trying to solve.*
   
   
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] himansh295 commented on pull request #3346: Avoiding Null Pointer Exception on line 113,148

Posted by "himansh295 (via GitHub)" <gi...@apache.org>.
himansh295 commented on PR #3346:
URL: https://github.com/apache/incubator-eventmesh/pull/3346#issuecomment-1455176311

   sure
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Alonexc commented on pull request #3346: Avoiding Null Pointer Exception on line 113,148

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3346:
URL: https://github.com/apache/incubator-eventmesh/pull/3346#issuecomment-1459605503

   these two changes or you should change it like this.
   ![image](https://user-images.githubusercontent.com/91315508/223634324-13943e87-4f97-44ba-8bcb-31cf21c4cd05.png)
   
   missing import.
   ![image](https://user-images.githubusercontent.com/91315508/223634474-99a91bc3-b352-406a-90e2-91a45870c8f8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

Re: [PR] Avoiding Null Pointer Exception on line 113,148 (eventmesh)

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3346:
URL: https://github.com/apache/eventmesh/pull/3346#issuecomment-1818168526

   This class has been deleted in #3746


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] Avoiding Null Pointer Exception on line 113,148 (eventmesh)

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo closed pull request #3346: Avoiding Null Pointer Exception on line 113,148
URL: https://github.com/apache/eventmesh/pull/3346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3346: Avoiding Null Pointer Exception on line 113,148

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3346:
URL: https://github.com/apache/incubator-eventmesh/pull/3346#discussion_r1129609314


##########
eventmesh-sdk-java/src/test/java/org/apache/eventmesh/client/grpc/util/EventMeshClientUtilTest.java:
##########
@@ -110,7 +110,7 @@ public void buildSimpleMessageWithCloudEventProto() {
             .hasFieldOrPropertyWithValue("seqNum", cloudEvent.getExtension(ProtocolKey.SEQ_NUM))
             .hasFieldOrPropertyWithValue("uniqueId", cloudEvent.getExtension(ProtocolKey.UNIQUE_ID))
             .hasFieldOrPropertyWithValue("content", new String(
-                EventFormatProvider.getInstance().resolveFormat(JsonFormat.CONTENT_TYPE).serialize(cloudEvent),
+                EventFormatProvider.getInstance().resolveFormat(JsonFormat.CONTENT_TYPE).serialize(Objects.requireNonNull(cloudEvent)),
                 StandardCharsets.UTF_8));

Review Comment:
   StandardCharsets.UTF_8 change to Constants.DEFAULT_CHARSET



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org