You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Norris Lee <no...@simba.com> on 2015/02/25 02:52:17 UTC

Review Request 31398: DRILL-2307: Detect DNS name resolution failure for better error messages in Drill Client

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31398/
-----------------------------------------------------------

Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.


Bugs: DRILL-2307
    https://issues.apache.org/jira/browse/DRILL-2307


Repository: drill-git


Description
-------

Zookeeper connection does not work with ODBC when DNS is not set up correctly on the Drillbit machine. There should be better error messages to help the user know of this issue rather than just failing with a standard connection failure message.


Diffs
-----

  contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
  contrib/native/client/src/include/drill/common.hpp e149ed1 

Diff: https://reviews.apache.org/r/31398/diff/


Testing
-------


Thanks,

Norris Lee


Re: Review Request 31398: DRILL-2307: Detect DNS name resolution failure for better error messages in Drill Client

Posted by Xiao Meng <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31398/#review73960
-----------------------------------------------------------

Ship it!


Ship It!

- Xiao Meng


On Feb. 25, 2015, 1:52 a.m., Norris Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31398/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 1:52 a.m.)
> 
> 
> Review request for drill, Alexander zarei, Parth Chandra, and Xiao Meng.
> 
> 
> Bugs: DRILL-2307
>     https://issues.apache.org/jira/browse/DRILL-2307
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Zookeeper connection does not work with ODBC when DNS is not set up correctly on the Drillbit machine. There should be better error messages to help the user know of this issue rather than just failing with a standard connection failure message.
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
>   contrib/native/client/src/include/drill/common.hpp e149ed1 
> 
> Diff: https://reviews.apache.org/r/31398/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Norris Lee
> 
>