You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/14 13:02:38 UTC
[kudu-CR](gh-pages) [site] add links required by ASF
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11209
to review the following change.
Change subject: [site] add links required by ASF
......................................................................
[site] add links required by ASF
ASF requires the following links to be included in the navigation
system[1]:
---
* "License" should link to: http://www.apache.org/licenses/
* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html
* "Thanks" should link to: http://www.apache.org/foundation/thanks.html
* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page
* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---
This commit adds all of these.
[1] https://www.apache.org/foundation/marks/pmcs#navigation
Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M index.html
3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
[site] add links required by ASF
ASF requires the following links to be included in the navigation
system[1]:
---
* "License" should link to: http://www.apache.org/licenses/
* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html
* "Thanks" should link to: http://www.apache.org/foundation/thanks.html
* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page
* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---
It also requires a trademark notice[2].
This commit adds all of these.
[1] https://www.apache.org/foundation/marks/pmcs#navigation
[2] https://www.apache.org/foundation/marks/pmcs#attributions
Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Reviewed-on: http://gerrit.cloudera.org:8080/11209
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M _includes/bottom_common.html
M _includes/top_common.html
M community.md
M index.html
4 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 16:07:42 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11209
to look at the new patch set (#6).
Change subject: [site] add links required by ASF
......................................................................
[site] add links required by ASF
ASF requires the following links to be included in the navigation
system[1]:
---
* "License" should link to: http://www.apache.org/licenses/
* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html
* "Thanks" should link to: http://www.apache.org/foundation/thanks.html
* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page
* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---
It also requires a trademark notice[2].
This commit adds all of these.
[1] https://www.apache.org/foundation/marks/pmcs#navigation
[2] https://www.apache.org/foundation/marks/pmcs#attributions
Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M community.md
M index.html
4 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/6
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
> Think this can go under an "Apache" drop down similar to the community one
Actually that's how I tried first, but then it wouldn't show on mobile. I checked it btw, this menu bar is still narrower than the actual page content so I think we should be fine. Let me know what you think
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Aug 2018 15:45:33 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
> It feels a bit weird to me to create a landing page to list 4 links so mobi
yeah, I understand that. Thats an unfortunate effect of our mobile drop down choices I suppose.
I think 4 top level links for things that are not very commonly used is also not great. Maybe we could add an Apache section to the existing Community drop down and add the link to the community page too?
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 14:34:24 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11209
to look at the new patch set (#2).
Change subject: [site] add links required by ASF
......................................................................
[site] add links required by ASF
ASF requires the following links to be included in the navigation
system[1]:
---
* "License" should link to: http://www.apache.org/licenses/
* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html
* "Thanks" should link to: http://www.apache.org/foundation/thanks.html
* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page
* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---
It also requires a trademark notice[2].
This commit adds all of these.
[1] https://www.apache.org/foundation/marks/pmcs#navigation
[2] https://www.apache.org/foundation/marks/pmcs#attributions
Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M index.html
3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/2
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
> Interesting. I see that we handle community by having a community page that
It feels a bit weird to me to create a landing page to list 4 links so mobile viewers can look into it. Do you have any suggestions about what could be there on the ASF landing page aside from the links?
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:52:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
Think this can go under an "Apache" drop down similar to the community one above? Otherwise the top nav could be pretty wide.
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Aug 2018 15:25:28 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md
File community.md:
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53
PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html)
We don't need {site.github.url} anymore?
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 15:21:01 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
> yeah, I understand that. Thats an unfortunate effect of our mobile drop dow
Good idea, added the links both under the community dropdown and to the community page under project information.
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 15:11:36 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11209
to look at the new patch set (#4).
Change subject: [site] add links required by ASF
......................................................................
[site] add links required by ASF
ASF requires the following links to be included in the navigation
system[1]:
---
* "License" should link to: http://www.apache.org/licenses/
* "Sponsorship" or "Donate" should link to:
http://www.apache.org/foundation/sponsorship.html
* "Thanks" should link to: http://www.apache.org/foundation/thanks.html
* "Security" should link to either to a project-specific page detailing
how users may securely report potential vulnerabilities, or to the main
http://www.apache.org/security/ page
* All projects must feature some prominent link back to the main ASF
homepage at http://www.apache.org/
---
It also requires a trademark notice[2].
This commit adds all of these.
[1] https://www.apache.org/foundation/marks/pmcs#navigation
[2] https://www.apache.org/foundation/marks/pmcs#attributions
Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
---
M _includes/bottom_common.html
M _includes/top_common.html
M community.md
M index.html
4 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/11209/4
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 16:07:24 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 5: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 17:56:15 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 7: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 14:33:47 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html
File _includes/bottom_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html@6
PS5, Line 6: Apache Kudu, Kudu, Apache, the Apache feather logo, and the Apache Kudu project logo are either registered trademarks or trademarks of The Apache Software Foundation in the United States and other countries.
nit: please wrap if possible
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md
File community.md:
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53
PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html)
> I replaced it with a relative URL, don't think the site.github.url is neces
We were using that before so that these links work even on non-top-level github pages domains, eg if you want to look at your own local fork of the github pages there is some special URL you can get to show it (I can't seem to find that URL right now) but it doesn't end up rooted at any particular domain
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 23:56:50 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:05:40 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html
File _includes/bottom_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/5/_includes/bottom_common.html@6
PS5, Line 6: Apache Kudu, Kudu, Apache, the Apache feather logo, and the Apache Kudu
> nit: please wrap if possible
Done
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md
File community.md:
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53
PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html)
> We were using that before so that these links work even on non-top-level gi
I think you mean http://apache.github.io/kudu/
Looking at the current community.html, it seems Jekyll is smart enough to handle this properly:
$ curl http://apache.github.io/kudu/community.html 2>/dev/null | grep "coding guidelines"
the project <a href="/kudu/docs/contributing.html#_code_style">coding guidelines</a> are before
In L95 you can see the source for this link looks like this: [coding guidelines](docs/contributing.html#_code_style)
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 16 Aug 2018 08:10:40 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md
File community.md:
http://gerrit.cloudera.org:8080/#/c/11209/4/community.md@53
PS4, Line 53: * [**Apache Kudu Committers list**](/committers.html)
> We don't need {site.github.url} anymore?
I replaced it with a relative URL, don't think the site.github.url is necessary in this case and TBH I'm not completely sure when it would be necessary. Tried to Google it too, seems like this was recommended at some point maybe? http://talk.jekyllrb.com/t/site-github-url/1157
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 15:51:02 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] add links required by ASF
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11209 )
Change subject: [site] add links required by ASF
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html
File _includes/top_common.html:
http://gerrit.cloudera.org:8080/#/c/11209/2/_includes/top_common.html@93
PS2, Line 93: <li><a href="https://www.apache.org/security/" target="_blank">Security</a></li>
> Actually that's how I tried first, but then it wouldn't show on mobile. I c
Interesting. I see that we handle community by having a community page that is linked to on mobile. Maybe we could add an Apache landing page? All of these links at the top bar feels like a lot even though it fits. I know it's a stylistic choice, so I am okay to be overridden on this.
--
To view, visit http://gerrit.cloudera.org:8080/11209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6983314e598eff73ac8f476924acd9d6f62196f
Gerrit-Change-Number: 11209
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Aug 2018 20:16:28 +0000
Gerrit-HasComments: Yes