[jira] [Commented] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381840#comment-16381840 ] 

ASF GitHub Bot commented on FLINK-8458:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5317#discussion_r166921740
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SequenceNumberingViewReader.java ---
    @@ -77,14 +78,35 @@ void requestSubpartitionView(
     		}
     	}
     
    -	InputChannelID getReceiverId() {
    +	@Override
    +	public void addCredit(int creditDeltas) {
    +	}
    +
    +	@Override
    +	public void setRegisteredAsAvailable(boolean isRegisteredAvailable) {
    +	}
    +
    +	@Override
    +	public boolean isRegisteredAsAvailable() {
    +		return false;
    --- End diff --
    
    Why this is not implemented?


> Add the switch for keeping both the old mode and the new credit-based mode
> --------------------------------------------------------------------------
>
>                 Key: FLINK-8458
>                 URL: https://issues.apache.org/jira/browse/FLINK-8458
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> After the whole feature of credit-based flow control is done, we should add a config parameter to switch on/off the new credit-based mode. To do so, we can roll back to the old network mode for any expected risks.
> The parameter is defined as {{taskmanager.network.credit-based-flow-control.enabled}} and the default value is true. This switch may be removed after next release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)