You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2016/04/12 21:07:59 UTC
Re: Review Request 45464: SAMZA-922 Host Affinity - Bug in
SamzaContainerRequest causes (recoverable) exceptions in YARN
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45464/#review128508
-----------------------------------------------------------
samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaContainerRequest.java (line 45)
<https://reviews.apache.org/r/45464/#comment191932>
But it is passed!? Or the name of the test is confusing..
- Boris Shkolnik
On March 30, 2016, 12:30 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45464/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 12:30 a.m.)
>
>
> Review request for samza, Navina Ramesh, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-922 Host Affinity - Bug in SamzaContainerRequest causes (recoverable) exceptions in YARN
>
>
> Diffs
> -----
>
> samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaContainerRequest.java a84e53fc2babe9a932cba2f758cf52103abb4407
> samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaContainerRequest.java aefae65df5f333d7e9ea405d9d3417dc27718a27
>
> Diff: https://reviews.apache.org/r/45464/diff/
>
>
> Testing
> -------
>
> Added a unit test and verified the change in the test job I'm using for SAMZA-886. When relaxed locality is false, these exceptions are much more problematic.
>
>
> Thanks,
>
> Jake Maes
>
>
Re: Review Request 45464: SAMZA-922 Host Affinity - Bug in
SamzaContainerRequest causes (recoverable) exceptions in YARN
Posted by Jake Maes <ja...@gmail.com>.
> On April 12, 2016, 7:07 p.m., Boris Shkolnik wrote:
> > samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaContainerRequest.java, line 45
> > <https://reviews.apache.org/r/45464/diff/1/?file=1318599#file1318599line45>
> >
> > But it is passed!? Or the name of the test is confusing..
Argument passing. If you have an alternate way to phrase it, I can change it.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45464/#review128508
-----------------------------------------------------------
On March 30, 2016, 12:30 a.m., Jake Maes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45464/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 12:30 a.m.)
>
>
> Review request for samza, Navina Ramesh, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-922 Host Affinity - Bug in SamzaContainerRequest causes (recoverable) exceptions in YARN
>
>
> Diffs
> -----
>
> samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaContainerRequest.java a84e53fc2babe9a932cba2f758cf52103abb4407
> samza-yarn/src/test/java/org/apache/samza/job/yarn/TestSamzaContainerRequest.java aefae65df5f333d7e9ea405d9d3417dc27718a27
>
> Diff: https://reviews.apache.org/r/45464/diff/
>
>
> Testing
> -------
>
> Added a unit test and verified the change in the test job I'm using for SAMZA-886. When relaxed locality is false, these exceptions are much more problematic.
>
>
> Thanks,
>
> Jake Maes
>
>