You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2018/03/22 19:04:15 UTC
[GitHub] trafodion pull request #1494: [TRAFODION-3005] Fix issues with keys on long ...
GitHub user DaveBirdsall opened a pull request:
https://github.com/apache/trafodion/pull/1494
[TRAFODION-3005] Fix issues with keys on long columns
This is a follow-on to JIRA TRAFODION-2977 (pull request https://github.com/apache/trafodion/pull/1473).
I made two changes here.
1. In the previous pull request, I added a check to the CREATE INDEX logic to make sure the key length is not too long. I put that check too early in the logic. I have now moved that check to the proper place.
2. It turns out that HBase uses rowIDs + possibly the HBase object name + some other info to make entries into another HBase structure internally, and imposes a 32767 key length limit on that. Unfortunately when we exceed the length limit on that internal structure, the HBase application (Trafodion in our case) experiences a hang. To avoid these hangs, we will further restrict maximum key length in Trafodion to 32000. The code change contains a detailed explanation of how this number was arrived at.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaveBirdsall/trafodion Trafodion3005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1494
----
commit 9c935c529c112afe889a05c5f9aa3498a16a2fac
Author: Dave Birdsall <db...@...>
Date: 2018-03-22T18:58:38Z
[TRAFODION-3005] Fix issues with keys on long columns
----
---
[GitHub] trafodion pull request #1494: [TRAFODION-3005] Fix issues with keys on long ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafodion/pull/1494
---