[GitHub] [calcite] cndaimin commented on issue #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'

[GitBox <gi...@apache.org>]

cndaimin commented on issue #1531: [CALCITE-3447]Fix 'equals' and 'hashcode' methods of class 'MutableScan'
URL: https://github.com/apache/calcite/pull/1531#issuecomment-546778219
 
 
   > Related with CALCITE-3167 (https://github.com/apache/calcite/pull/1294/files)
   > Check -- https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java#L192
   > Note that RelOptMaterializations use the same RelOptPlanner to process `query` and `materialization`, thus different nodes with the same digest will share the same vertex in
   > the plan graph, i.e. the same TableScan instance will be used for the description in this PR.
   
   Yes, call from `RelOptMaterializations#useMaterializedViews` is fine and the reason is that `HepPlanner` make two nodes with same digest into one. This bypassed the bug of the `equivalents` map in `SubstitutionVisitor`, whose correctness should not rely on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services