You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/20 04:45:00 UTC
[jira] [Commented] (IMPALA-10958) Decouple
getConstraintsInformation from hive.ql.metadata.Table
[ https://issues.apache.org/jira/browse/IMPALA-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430876#comment-17430876 ]
ASF subversion and git services commented on IMPALA-10958:
----------------------------------------------------------
Commit cae36149aace90c256131fc4ba30f1cc5dae561e in impala's branch refs/heads/master from Yu-Wen Lai
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=cae3614 ]
IMPALA-10958: Decouple getConstraintsInformation from
hive.ql.metadata.Table
After HIVE-22782, ql.metadata.Table object has no methods to set
PrimaryKeyInfo and ForeignKeyInfo alone. However, we call these two
functions In DescribeResultFactory to set constraints and pass the
table into HiveMetadataFormatUtils. Instead of calling the methods
from table, we can directly pass PrimaryKeyInfo and ForeignKeyInfo
to HiveMetadataFormatUtils so that Impala won't be influenced even
though the table class changes interface.
Additionally, we can get rid of ql.metadata.Table for
getTableInformation altogether since it just needs
metastore.api.Table internally.
Tests:
Ran core tests.
Change-Id: I2dfc54ae2f995dc4ab735d17dbbad9a48f6633da
Reviewed-on: http://gerrit.cloudera.org:8080/17910
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Vihang Karajgaonkar <vi...@cloudera.com>
> Decouple getConstraintsInformation from hive.ql.metadata.Table
> --------------------------------------------------------------
>
> Key: IMPALA-10958
> URL: https://issues.apache.org/jira/browse/IMPALA-10958
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: Yu-Wen Lai
> Assignee: Yu-Wen Lai
> Priority: Major
>
> After [HIVE-22782|http://issues.apache.org/jira/browse/HIVE-22782], ql.metadata.Table object has no methods to set PrimaryKeyInfo and ForeignKeyInfo alone. However, we call these two functions In DescribeResultFactory to set constraints and pass the table into HiveMetadataFormatUtils. Instead of calling the methods from table, we can directly pass PrimaryKeyInfo and ForeignKeyInfo to HiveMetadataFormatUtils so that Impala won't be influenced even though the table class changes interface.
> Additionally, we can get rid of ql.metadata.Table for getTableInformation altogether since it just needs metastore.api.Table internally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org