You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/30 16:50:08 UTC

Review Request 34843: yarn.admin.acl set to empty string causes all data to be exposed in Tez view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34843/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-11557
    https://issues.apache.org/jira/browse/AMBARI-11557


Repository: ambari


Description
-------

yarn-site.xml had the following:

    
    
    
        <property>
          <name>yarn.admin.acl</name>
          <value></value>
        </property>
    

In this case, all entities regardless of the acl specs were accessible to all
users.

By adding a space in the value, the acl enforcement worked correctly.

\cc zshen tathiapinya


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/providers/modify_properties_file.py e71abb8 
  ambari-common/src/main/python/resource_management/libraries/providers/properties_file.py 1d21649 
  ambari-common/src/main/python/resource_management/libraries/providers/xml_config.py 6f6c2a1 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml dd413a2 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml 63234f4 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml c1db0f9 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml d7bd90e 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json ff8dc2c 
  ambari-web/app/data/HDP2.2/site_properties.js 09d9283 

Diff: https://reviews.apache.org/r/34843/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 34843: yarn.admin.acl set to empty string causes all data to be exposed in Tez view

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34843/#review87427
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Червень 10, 2015, 7:56 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34843/
> -----------------------------------------------------------
> 
> (Updated Червень 10, 2015, 7:56 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-11557
>     https://issues.apache.org/jira/browse/AMBARI-11557
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> yarn-site.xml had the following:
> 
>     
>     
>     
>         <property>
>           <name>yarn.admin.acl</name>
>           <value></value>
>         </property>
>     
> 
> In this case, all entities regardless of the acl specs were accessible to all
> users.
> 
> By adding a space in the value, the acl enforcement worked correctly.
> 
> \cc zshen tathiapinya
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json e9482ab 
> 
> Diff: https://reviews.apache.org/r/34843/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 34843: yarn.admin.acl set to empty string causes all data to be exposed in Tez view

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34843/
-----------------------------------------------------------

(Updated June 10, 2015, 4:56 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-11557
    https://issues.apache.org/jira/browse/AMBARI-11557


Repository: ambari


Description
-------

yarn-site.xml had the following:

    
    
    
        <property>
          <name>yarn.admin.acl</name>
          <value></value>
        </property>
    

In this case, all entities regardless of the acl specs were accessible to all
users.

By adding a space in the value, the acl enforcement worked correctly.

\cc zshen tathiapinya


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json e9482ab 

Diff: https://reviews.apache.org/r/34843/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 34843: yarn.admin.acl set to empty string causes all data to be exposed in Tez view

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34843/#review85867
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Травень 30, 2015, 5:50 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34843/
> -----------------------------------------------------------
> 
> (Updated Травень 30, 2015, 5:50 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-11557
>     https://issues.apache.org/jira/browse/AMBARI-11557
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> yarn-site.xml had the following:
> 
>     
>     
>     
>         <property>
>           <name>yarn.admin.acl</name>
>           <value></value>
>         </property>
>     
> 
> In this case, all entities regardless of the acl specs were accessible to all
> users.
> 
> By adding a space in the value, the acl enforcement worked correctly.
> 
> \cc zshen tathiapinya
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/providers/modify_properties_file.py e71abb8 
>   ambari-common/src/main/python/resource_management/libraries/providers/properties_file.py 1d21649 
>   ambari-common/src/main/python/resource_management/libraries/providers/xml_config.py 6f6c2a1 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml dd413a2 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml 63234f4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml c1db0f9 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml d7bd90e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json ff8dc2c 
>   ambari-web/app/data/HDP2.2/site_properties.js 09d9283 
> 
> Diff: https://reviews.apache.org/r/34843/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>