You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/11 10:38:32 UTC

[GitHub] [apisix-dashboard] membphis opened a new issue #787: makefile: for `make release-src`, it should release the source code

membphis opened a new issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787


   https://github.com/apache/apisix-dashboard/blob/v2.0/Makefile#L93
   
   that is wrong, for `make release-src`, it should release the source code. 
   
   but we released binary file now, this is wrong.
   
   ```
   .PHONY: release-src
   release-src:
   	tar –cf dashboard.tar ./output/*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gxthrj commented on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-728842717


   @membphis Can we close this issue now? 
   The document has changed the original purpose of packaging the `output` directory.
   `make release-src` is for source release now. #816 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gxthrj commented on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725774311


   ok, we can call it `make release`,the release package contains the binary file of `manager-api` and static files of `web`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis edited a comment on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725346729


   @gxthrj you can take a look at this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-728902882


   We could close this one IMO.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725850943


   make-release is more semantic and clearer. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on issue #787: makefile: for `make release-src`, it should release the source code

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #787:
URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725346729


   @gxthrj you can take a look at this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org