You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/01 21:50:29 UTC
[GitHub] [lucene-solr-operator] HoustonPutman opened a new pull request #229: Resolve dependency license handling
HoustonPutman opened a new pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229
Resolves #228
The intent of this PR is to resolve the dependency license issue, so that docker images built for the Solr Operator, as well as source releases, follow ASF policy.
Changes:
- Docker image shouldn't need a source release, as well as a release with all of the dependency code vendored (I think). We might be able to just package the licenses (and code for licenses that require that source code be provided with any released binaries)
- Some necessary additions to the NOTICES file
Thoughts:
- Do we need to store the licenses in the code and check them in? It's not hard and we can automate this if we need to.
- I don't think we need to include an entry for each dependency in the NOTICE file, but I could be wrong there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #229: Resolve dependency license handling
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #229: Resolve dependency license handling
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229#discussion_r590757492
##########
File path: dependency_licenses.csv
##########
@@ -0,0 +1,53 @@
+cloud.google.com/go/compute/metadata,Unknown,Apache-2.0
Review comment:
If not, that's fine. We could remove the whole workflow around this. If you don't think it's necessary, then I can tear it all out.
I think it's good to have so that we can keep track of the dependency Licenses that PRs are adding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #229: Resolve dependency license handling
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229#discussion_r590713737
##########
File path: NOTICE
##########
@@ -26,3 +26,12 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+The Solr Operator project is built using Kubebuilder, which is Apache 2.0 licensed.
+ https://github.com/kubernetes-sigs/kubebuilder
+
+The reconcileStorageFinalizer login in
+ controllers/solrcloud_controller.go
+was influenced by the same logic in the Zookeeper Operator, which is Apache 2.0 licensed.
+ https://github.com/pravega/zookeeper-operator/blob/v0.2.9/pkg/controller/zookeepercluster/zookeepercluster_controller.go#L629)
+Copyright (c) 2020 Dell Inc., or its subsidiaries. All Rights Reserved.
Review comment:
nit: missing newline
##########
File path: dependency_licenses.csv
##########
@@ -0,0 +1,53 @@
+cloud.google.com/go/compute/metadata,Unknown,Apache-2.0
Review comment:
Do we need to store this file (in this format) ?
##########
File path: hack/install_dependencies.sh
##########
@@ -32,3 +32,6 @@ if !(which kubebuilder && (kubebuilder version | grep ${kubebuilder_version}));
else
echo "Kubebuilder already installed at $(which kubebuilder)"
fi
+
+# Install go-licenses
+go get github.com/google/go-licenses
Review comment:
nit: new line
##########
File path: .github/workflows/docker.yaml
##########
@@ -17,4 +17,4 @@ jobs:
# Cleanup & Install dependencies
- run: docker --version
- - run: make docker-vendor-build
\ No newline at end of file
+ - run: make docker-build
Review comment:
nit: new line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #229: Resolve dependency license handling
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229#issuecomment-794475698
This approach sounds good to go according to the feedback in [LEGAL-562](https://issues.apache.org/jira/browse/LEGAL-562)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #229: Resolve dependency license handling
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #229:
URL: https://github.com/apache/lucene-solr-operator/pull/229#discussion_r590777792
##########
File path: dependency_licenses.csv
##########
@@ -0,0 +1,53 @@
+cloud.google.com/go/compute/metadata,Unknown,Apache-2.0
Review comment:
Makes sense :)
Let's keep it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org