You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/03/18 20:58:02 UTC

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12781 )

Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file
......................................................................

IMPALA-8317: Add support for list type flags in Impala shell config file

This patch adds support for list type flags in Impala shell config
file, i.e. those that use action="append", such as --var and
--query_option. To make it less error-prone, this patch also updates
the logic for bool flags in the config file to also look at the
correct type from the argument parser instead of relying on whether or
not the default values are set in impala_shell_config_defaults.py.

Testing:
- Added a new test for list type flags
- Ran all shell E2E tests

Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73
---
M shell/option_parser.py
M tests/shell/good_impalarc
M tests/shell/test_shell_commandline.py
3 files changed, 20 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/81/12781/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73
Gerrit-Change-Number: 12781
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>