You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2022/01/20 01:18:56 UTC

[logging-log4j2] 02/03: Log4j 1.2 bridge now logs a warning instead of throwing an NullPointerException when building a Syslog appender with a missing "SyslogHost" param.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit cad725d9c1b2f3c8b65dfdcf89d0e5dce537acbc
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jan 19 20:17:51 2022 -0500

    Log4j 1.2 bridge now logs a warning instead of throwing an
    NullPointerException when building a Syslog appender with a missing
    "SyslogHost" param.
---
 .../java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java
index 21b9f96..d2e6aa9 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/SyslogAppenderBuilder.java
@@ -45,6 +45,7 @@ import org.apache.logging.log4j.core.layout.SyslogLayout;
 import org.apache.logging.log4j.core.net.Facility;
 import org.apache.logging.log4j.core.net.Protocol;
 import org.apache.logging.log4j.status.StatusLogger;
+import org.apache.logging.log4j.util.Strings;
 import org.w3c.dom.Element;
 
 /**
@@ -165,7 +166,7 @@ public class SyslogAppenderBuilder extends AbstractBuilder implements AppenderBu
         //  If not an unbracketed IPv6 address then
         //      parse as a URL
         //
-        String[] parts = syslogHost.split(":");
+        final String[] parts = syslogHost != null ? syslogHost.split(":") : Strings.EMPTY_ARRAY;
         if (parts.length == 1) {
             host.set(parts[0]);
             port.set(DEFAULT_PORT);