You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by tatjana19 <gi...@git.apache.org> on 2015/08/13 13:32:13 UTC
[GitHub] wicket pull request: Added return type for chaining
GitHub user tatjana19 opened a pull request:
https://github.com/apache/wicket/pull/134
Added return type for chaining
As it is in Component
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tatjana19/wicket patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit c59e256cfd1ba94a64e5213c8497e67305ce2a42
Author: tatjana19 <ko...@gmail.com>
Date: 2015-08-13T11:32:04Z
Added return type for chaining
As it is in Component
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Added return type for chaining
Posted by tatjana19 <gi...@git.apache.org>.
Github user tatjana19 commented on the pull request:
https://github.com/apache/wicket/pull/134#issuecomment-130648340
Of course because of semantic versioning i think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Added return type for chaining
Posted by tatjana19 <gi...@git.apache.org>.
Github user tatjana19 commented on the pull request:
https://github.com/apache/wicket/pull/134#issuecomment-134102919
Another option would be to create a new inteface like this:
----------------------------------------------------
package org.apache.wicket;
import org.apache.wicket.model.IModel;
/**
* An interface for all {@link Component components} with type-safe accessors and mutators
* for the model and its object.
*
* @param <T>
* the type of the model object
*/
public interface IGenericModel<T>
{
/**
* Typesafe getter for the model
*
* @return the model
*/
IModel<T> getModel();
/**
* Typesafe setter for the model
*
* @param model
* the new model
* @return This for chaining
*/
Component setModel(IModel<T> model);
/**
* Typesafe setter for the model object
*
* @param object
* the new model object
* @return This for chaining
*/
Component setModelObject(T object);
/**
* Typesafe getter for the model's object
*
* @return the model object
*/
T getModelObject();
}
----------------------------------------------------
The IGenericComponent is for use for generic Model so the new name IGenericModel would fit better i think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Added return type for chaining
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/134#issuecomment-130631999
This is an API break and will have to wait Wicket 8.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Added return type for chaining
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---