You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sean Busbey (JIRA)" <ji...@apache.org> on 2017/10/31 18:44:00 UTC

[jira] [Commented] (HADOOP-14998) Make AuthenticationFilter @Public

    [ https://issues.apache.org/jira/browse/HADOOP-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227307#comment-16227307 ] 

Sean Busbey commented on HADOOP-14998:
--------------------------------------

Could this wait until later? We already know that it relies on non-Hadoop APIs (at least javax.servlet.Filter), something we know is a problem in our API and we've only done a bit to try to fix thus far. The space between beta and GA seems like a poor time to make the problem worse by promising downstreamers we'll start supporting their use of our heretofore internals.

> Make AuthenticationFilter @Public
> ---------------------------------
>
>                 Key: HADOOP-14998
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14998
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Robert Kanter
>            Assignee: Bharat Viswanadham
>
> {{org.apache.hadoop.security.authentication.server.AuthenticationFilter}} is currently marked as {{\@Private}} and {{\@Unstable}}.  
> {code:java}
> @InterfaceAudience.Private
> @InterfaceStability.Unstable
> public class AuthenticationFilter implements Filter {
> {code}
> However, many other projects (e.g. Oozie, Hive, Solr, HBase, etc) have been using it for quite some time without having any compatibility issues AFAIK.  It doesn't seem to have had any breaking changes in quite some time.  On top of that, it implements {{javax.servlet.Filter}}, so it can't change too widely anyway.  {{AuthenticationFilter}} provides a lot of useful code for dealing with tokens, Kerberos, etc, and we should encourage related projects to re-use this code instead of rolling their own.
> I propose we change it to {{\@Public}} and {{\@Evolving}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org