You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2023/11/21 22:44:08 UTC

[PR] Update elasticity MergeTablets to use MERGED marker [accumulo]

cshannon opened a new pull request, #3975:
URL: https://github.com/apache/accumulo/pull/3975

   The MERGED marker is set on the last tablet of the merged range after metadata has been updated so that it is possible to know whether or not the files were already fenced. If the marker exists then the fencing for the last tablet can be skipped as the process was restarted.
   
   This is a follow on to #3957 and applies that changes that were done in main in `TabletGroupWatcher` to the `MergeTablets` and `DeleteTablets` fate ops.
   
   The existing tests in MergeIT verify that the merged marker is properly cleared.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update elasticity MergeTablets to use MERGED marker [accumulo]

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #3975:
URL: https://github.com/apache/accumulo/pull/3975#issuecomment-1821825332

   @keith-turner - I put the code to clean up the `MERGED` marker in `DeleteTablets` because this seemed like the simplest place to put it. I could also move it into `FinishTableRangeOp` but that currently can be called even if there is no marker to clean up (such as if only 1 tablet for the merge range and it skips) where as `DeleteTablets` should only be called if there is a `MERGED` marker to clean up. But I can move the clean up there if you think that makes more sense and just check if the marker exists before removing it or just remove it regardless (I don't think there's any harm in deleting a column that doesn't exist)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update elasticity MergeTablets to use MERGED marker [accumulo]

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on code in PR #3975:
URL: https://github.com/apache/accumulo/pull/3975#discussion_r1408523810


##########
core/src/test/java/org/apache/accumulo/core/metadata/schema/TabletMetadataTest.java:
##########
@@ -416,6 +416,7 @@ public void testBuilder() {
     assertEquals(159L, tm3.getSelectedFiles().getFateTxId());
     assertFalse(tm3.getSelectedFiles().initiallySelectedAll());
     assertEquals(selFiles.getMetadataValue(), tm3.getSelectedFiles().getMetadataValue());
+    assertTrue(tm3.hasMerged());

Review Comment:
   I will add an assertion for that above to one of the other TabletMetadata objects that doesn't set it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update elasticity MergeTablets to use MERGED marker [accumulo]

Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #3975:
URL: https://github.com/apache/accumulo/pull/3975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update elasticity MergeTablets to use MERGED marker [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3975:
URL: https://github.com/apache/accumulo/pull/3975#discussion_r1406418471


##########
core/src/test/java/org/apache/accumulo/core/metadata/schema/TabletMetadataTest.java:
##########
@@ -416,6 +416,7 @@ public void testBuilder() {
     assertEquals(159L, tm3.getSelectedFiles().getFateTxId());
     assertFalse(tm3.getSelectedFiles().initiallySelectedAll());
     assertEquals(selFiles.getMetadataValue(), tm3.getSelectedFiles().getMetadataValue());
+    assertTrue(tm3.hasMerged());

Review Comment:
   Would be good to add another check somewhere else for the case when merged is not set to enure its false.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org