[jira] [Commented] (CASSANALYTICS-179) Correct total timeout calculation for getAllNodeSettings

["Yifan Cai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANALYTICS-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099489#comment-18099489 ] 

Yifan Cai commented on CASSANALYTICS-179:
-----------------------------------------

+1 thanks for the fix

> Correct total timeout calculation for getAllNodeSettings
> --------------------------------------------------------
>
>                 Key: CASSANALYTICS-179
>                 URL: https://issues.apache.org/jira/browse/CASSANALYTICS-179
>             Project: Apache Cassandra Analytics
>          Issue Type: Bug
>          Components: Writer
>            Reporter: Lukasz Antoniak
>            Assignee: Lukasz Antoniak
>            Priority: Normal
>
> Total timeout waiting for response to all node settings is calculated as:
> {code:java}
> conf.getSidecarRequestMaxRetryDelayMillis() * conf.getSidecarRequestRetries() * allNodeSettingFutures.size(); {code}
> The per-request timeout is not taken into account. Most likely sufficient timeout is reached due to multiplication by number of "futures". Calculation should be corrected to:
> {code:java}
> (maxRetryDelayMillis + requestTimeout) * maxRetries {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org