You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/12 20:22:50 UTC
[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #38: WIP: refactor and cleanups
tom-pytel opened a new pull request #38:
URL: https://github.com/apache/skywalking-nodejs/pull/38
Centralizing some functionality, minor fixes and cleanups, not for merge yet, will advise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #38: Refactor and cleanups
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #38:
URL: https://github.com/apache/skywalking-nodejs/pull/38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #38: WIP: refactor and cleanups
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #38:
URL: https://github.com/apache/skywalking-nodejs/pull/38#issuecomment-798503535
* Changed Axios hook to higher level which will include all middleware in span time as well as allow adapters other than http.
* Changed how http client request works if it is used by a higher level plugin (like Axios) - now it just does nothing to avoid duplicating work that the higher level plugin does and allows higher level plugin to work if http plugin is disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #38: WIP: refactor and cleanups
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #38:
URL: https://github.com/apache/skywalking-nodejs/pull/38#issuecomment-798903245
I think this is good to merge here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #38: WIP: refactor and cleanups
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #38:
URL: https://github.com/apache/skywalking-nodejs/pull/38#issuecomment-798680786
This PR makes that express can work if http plugin is disabled and vice-versa and also that express will not duplicate http plugin work if that is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org