[GitHub] gigasquid edited a comment on issue #11205: Clojure Contrib Package

[GitBox <gi...@apache.org>]

gigasquid edited a comment on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-399594324
 
 
   @nswamy @larroy I switched the project.clj to use the linux cpu version to make it ready for CI.
   
   @didibus - good point. A discussion needs to made concerning the versioning of the clojure-package. Right now the dependencies and main project version is in the `project.clj` file 
   
   ```clojure
   (defproject org.apache.mxnet.contrib.clojure/clojure-mxnet "1.2.1-SNAPSHOT"
     :description "Clojure package for MXNet"
     :dependencies [[org.clojure/clojure "1.9.0"]
                    [t6/from-scala "0.3.0"]
                    ;; Choose the right dependency for your system
                    ;[org.apache.mxnet/mxnet-full_2.11-osx-x86_64-cpu "1.2.1"]
                    [org.apache.mxnet/mxnet-full_2.11-linux-x86_64-cpu "1.2.1"]
                    ;[org.apache.mxnet/mxnet-full_2.11-linux-x86_64-gpu "1.2.1"]
                    [org.clojure/tools.logging "0.4.0"]
                    [org.apache.logging.log4j/log4j-core "2.8.1"]
                    [org.apache.logging.log4j/log4j-api "2.8.1"]
                    [org.slf4j/slf4j-log4j12 "1.7.25" :exclusions [org.slf4j/slf4j-api]]]
   ```
   The dependencies used are the Scala `1.2.1` jars. If the clojure project would be deployed to clojars or nexus, the `org.apache.mxnet.contrib.clojure/clojure-mxnet "1.2.1-SNAPSHOT"` would have to be changed to `org.apache.mxnet.contrib.clojure/clojure-mxnet "1.2.1"` first and then would have to be incremented.
   
   For a point of reference, the Scala package is now sitting at `1.3.0-SNAPSHOT`. So maybe the clojure package should be set to that as well.
   
   We can choose to have the clojure-package align with the main package version or have its own version. I'm fine with whatever we come up with. 
   
   With a new language package there will be some process stuff to work through on how to get into CI and handle versioning and deployment. I expect and encourage some conversations to be had about how best to handle it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services