You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/08/11 15:28:16 UTC

[jira] Created: (SLING-1640) Add ResourceResolver.copy(Map) method

Add ResourceResolver.copy(Map) method 
--------------------------------------

                 Key: SLING-1640
                 URL: https://issues.apache.org/jira/browse/SLING-1640
             Project: Sling
          Issue Type: New Feature
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For: JCR Resource 2.0.8, API 2.1.0


As discussed on the list the ResourceResolver interface should be extended with a new method:

    ResourceResolver copy(Map credentials);

This method creates a new ResourceResolver as follows:

    // start with original credentials
    Map newCredentials = new HashMap(current resolver credentials);

    // overlay with provided credentials
    newCredentials.addAll(credentials);

    // return a new ResourceResolver
    return resourceResolverFactory.login(newCredentials);

This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-1640) Add ResourceResolver.clone(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated SLING-1640:
-------------------------------------

        Summary: Add ResourceResolver.clone(Map) method   (was: Add ResourceResolver.copy(Map) method )
    Description: 
As discussed on the list the ResourceResolver interface should be extended with a new method:

    ResourceResolver clone(Map credentials);

This method creates a new ResourceResolver as follows:

    // start with original credentials
    Map newCredentials = new HashMap(current resolver credentials);

    // overlay with provided credentials
    newCredentials.addAll(credentials);

    // return a new ResourceResolver
    return resourceResolverFactory.login(newCredentials);

This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

  was:
As discussed on the list the ResourceResolver interface should be extended with a new method:

    ResourceResolver copy(Map credentials);

This method creates a new ResourceResolver as follows:

    // start with original credentials
    Map newCredentials = new HashMap(current resolver credentials);

    // overlay with provided credentials
    newCredentials.addAll(credentials);

    // return a new ResourceResolver
    return resourceResolverFactory.login(newCredentials);

This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.


clone is a better name than copy

> Add ResourceResolver.clone(Map) method 
> ---------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver clone(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1640) Add ResourceResolver.clone(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897292#action_12897292 ] 

Felix Meschberger commented on SLING-1640:
------------------------------------------

Renamed the API method from copy to clone in Rev. 984422.
Implemented the clone method in the jcr/resource bundle along with a unit test in Rev. 984431.

> Add ResourceResolver.clone(Map) method 
> ---------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver clone(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1640) Add ResourceResolver.clone(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897306#action_12897306 ] 

Felix Meschberger commented on SLING-1640:
------------------------------------------

For the contrib/extensions/bgservlets project: In Rev. 984442 replaced AuthenticationInfo request attribute with new ResourceResolver.clone method. This allows removing the reference to the ResourceResolverFactory and the dependency on Commons Auth.

> Add ResourceResolver.clone(Map) method 
> ---------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver clone(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-1640) Add ResourceResolver.copy(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated SLING-1640:
-------------------------------------

    Component/s: API
                 JCR

> Add ResourceResolver.copy(Map) method 
> --------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver copy(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1640) Add ResourceResolver.clone(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-1640.
--------------------------------------

    Resolution: Fixed

This has been implemented and passes the tests. Thus resolving.

> Add ResourceResolver.clone(Map) method 
> ---------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver clone(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1640) Add ResourceResolver.copy(Map) method

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897274#action_12897274 ] 

Felix Meschberger commented on SLING-1640:
------------------------------------------

Added the API in Rev. 984412 plus some more JavaDoc to the ResourceResolverFactory method.

> Add ResourceResolver.copy(Map) method 
> --------------------------------------
>
>                 Key: SLING-1640
>                 URL: https://issues.apache.org/jira/browse/SLING-1640
>             Project: Sling
>          Issue Type: New Feature
>          Components: API, JCR
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: JCR Resource 2.0.8, API 2.1.0
>
>
> As discussed on the list the ResourceResolver interface should be extended with a new method:
>     ResourceResolver copy(Map credentials);
> This method creates a new ResourceResolver as follows:
>     // start with original credentials
>     Map newCredentials = new HashMap(current resolver credentials);
>     // overlay with provided credentials
>     newCredentials.addAll(credentials);
>     // return a new ResourceResolver
>     return resourceResolverFactory.login(newCredentials);
> This new method allows for the removal of the AuthenticationInfo object from the request attributes (as discussed in SLING-1445) and allows for a better implementation of the background servlet execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.