[jira] Commented: (OPENNLP-85) Refactor ChunkSample class

["William Colen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986517#action_12986517 ] 

William Colen commented on OPENNLP-85:
--------------------------------------

I changed only items 2 and 3. According to Jörn we should keep using Lists internally, as explained in the mail thread: http://mail-archives.apache.org/mod_mbox/incubator-opennlp-dev/201101.mbox/%3C4D3EF9FF.7070907@gmail.com%3E 

> Refactor ChunkSample class
> --------------------------
>
>                 Key: OPENNLP-85
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-85
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Chunker
>    Affects Versions: tools-1.5.1-incubating
>            Reporter: William Colen
>            Assignee: William Colen
>            Priority: Trivial
>             Fix For: tools-1.5.1-incubating
>
>
> The class needs some improvements:
> 1. Internally it works with Lists, but all methods outputs Arrays, it is always making Lists to Arrays conversions. Better to work with arrays directly.
> 2. Create a static method to create spans of phrase chunks 
> 3. Add javadoc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.