You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2025/09/25 07:45:24 UTC

Re: [PR] [WIP][SPARK-53707] Improve attribute metadata handling. [spark]

cloud-fan commented on code in PR #52449:
URL: https://github.com/apache/spark/pull/52449#discussion_r2378079110


##########
sql/api/src/main/scala/org/apache/spark/sql/types/Metadata.scala:
##########
@@ -247,6 +247,13 @@ object Metadata {
         throw DataTypeErrors.unsupportedJavaTypeError(other.getClass)
     }
   }
+
+  def removeMetadataWithKeys(

Review Comment:
   shall we make it an instance method of `Metadata`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org