You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/07/31 15:29:36 UTC
[jira] [Resolved] (QPID-4124) [Java Broker] TransactionTimout
logging has duplication and some erroneously uses default Object.toString
[ https://issues.apache.org/jira/browse/QPID-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-4124.
----------------------------------
Resolution: Fixed
Keith and I reviewed the patch, and have made some modifications before committing it:
- Use an instance of the helper per-channel instead of creating 2 new ones every time the check is performed.
- Add some tests for the case when the timeouts are 0, and the operational logging is disabled.
- (issue with the existing code) Move the closures right after the respective idle/open checks such that you only get the relevant log messages before the close operation is performed, reducing duplication.
> [Java Broker] TransactionTimout logging has duplication and some erroneously uses default Object.toString
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-4124
> URL: https://issues.apache.org/jira/browse/QPID-4124
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14, 0.15, 0.16, 0.17, 0.18
> Reporter: Philip Harvey
> Assignee: Philip Harvey
> Priority: Trivial
> Fix For: 0.19
>
> Attachments: 0001-QPID-4124-Improved-logging-that-is-produced-when-the.patch, 0001-QPID-4124-log-output-should-use-LogSubject.toLogStri.patch
>
>
> In AMQChannel, code such as
> _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toString() ...
> should be replaced by
> _logger.warn("IDLE TRANSACTION ALERT " + _logSubject.toLogString() ...
> because the first example uses Object.toString, which is not very useful for logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org