You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Brian Minchau (JIRA)" <xa...@xml.apache.org> on 2006/03/07 23:10:39 UTC
[jira] Created: (XALANJ-2275) Serializer's methods to set
xsl:output properties is brittle.
Serializer's methods to set xsl:output properties is brittle.
-------------------------------------------------------------
Key: XALANJ-2275
URL: http://issues.apache.org/jira/browse/XALANJ-2275
Project: XalanJ2
Type: Improvement
Versions: Latest Development Code
Reporter: Brian Minchau
The serializer's code to set values from xsl:output attributes is brittle.
Setting a writer or OutputStream involves internal "init" methods that take java.util.Properties objects. Setting an OutputStream should not need to do all that. The only interaction with the properties is the encoding, which would be used in the creation of the java.io.Writer that wraps the OutputStream, but that is about it.
The code is also brittle with respect to whether the values set are default values or explicit values,
say from a stylesheet or from JAXP APIs.
In the long run many methods on the serializer's XSLOutputAttributes interface should go away.
In their place a more generic methods should exist:
public void setOutputPropertyDefault(String name, String val);
public void setOutputProperty(String name, String val);
public String getOutputPropertyDefault(String name);
public String getOutputProperty(String name);
Through these methods one can set/get a default or non-default property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Closed: (XALANJ-2275) Serializer's methods to set xsl:output
properties is brittle.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Minchau closed XALANJ-2275.
---------------------------------
closing this issue.
> Serializer's methods to set xsl:output properties is brittle.
> -------------------------------------------------------------
>
> Key: XALANJ-2275
> URL: https://issues.apache.org/jira/browse/XALANJ-2275
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: 2.7
> Reporter: Brian Minchau
> Fix For: 2.7.1
>
> Attachments: patch2.txt
>
>
> The serializer's code to set values from xsl:output attributes is brittle.
> Setting a writer or OutputStream involves internal "init" methods that take java.util.Properties objects. Setting an OutputStream should not need to do all that. The only interaction with the properties is the encoding, which would be used in the creation of the java.io.Writer that wraps the OutputStream, but that is about it.
> The code is also brittle with respect to whether the values set are default values or explicit values,
> say from a stylesheet or from JAXP APIs.
> In the long run many methods on the serializer's XSLOutputAttributes interface should go away.
> In their place a more generic methods should exist:
> public void setOutputPropertyDefault(String name, String val);
> public void setOutputProperty(String name, String val);
> public String getOutputPropertyDefault(String name);
> public String getOutputProperty(String name);
> Through these methods one can set/get a default or non-default property.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2275) Serializer's methods to set
xsl:output properties is brittle.
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2275?page=all ]
Brian Minchau resolved XALANJ-2275:
-----------------------------------
Fix Version: Latest Development Code
Resolution: Fixed
Fixed, patch was committed.
> Serializer's methods to set xsl:output properties is brittle.
> -------------------------------------------------------------
>
> Key: XALANJ-2275
> URL: http://issues.apache.org/jira/browse/XALANJ-2275
> Project: XalanJ2
> Type: Improvement
> Versions: Latest Development Code
> Reporter: Brian Minchau
> Fix For: Latest Development Code
> Attachments: patch2.txt
>
> The serializer's code to set values from xsl:output attributes is brittle.
> Setting a writer or OutputStream involves internal "init" methods that take java.util.Properties objects. Setting an OutputStream should not need to do all that. The only interaction with the properties is the encoding, which would be used in the creation of the java.io.Writer that wraps the OutputStream, but that is about it.
> The code is also brittle with respect to whether the values set are default values or explicit values,
> say from a stylesheet or from JAXP APIs.
> In the long run many methods on the serializer's XSLOutputAttributes interface should go away.
> In their place a more generic methods should exist:
> public void setOutputPropertyDefault(String name, String val);
> public void setOutputProperty(String name, String val);
> public String getOutputPropertyDefault(String name);
> public String getOutputProperty(String name);
> Through these methods one can set/get a default or non-default property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2275) Serializer's methods to set
xsl:output properties is brittle.
Posted by "Yash Talwar (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2275?page=comments#action_12369328 ]
Yash Talwar commented on XALANJ-2275:
-------------------------------------
I have reviewed the patch provided by Brian, The changes made look good to me. I find the it is easier to follow the code after the changes.
I approve.
> Serializer's methods to set xsl:output properties is brittle.
> -------------------------------------------------------------
>
> Key: XALANJ-2275
> URL: http://issues.apache.org/jira/browse/XALANJ-2275
> Project: XalanJ2
> Type: Improvement
> Versions: Latest Development Code
> Reporter: Brian Minchau
> Attachments: patch2.txt
>
> The serializer's code to set values from xsl:output attributes is brittle.
> Setting a writer or OutputStream involves internal "init" methods that take java.util.Properties objects. Setting an OutputStream should not need to do all that. The only interaction with the properties is the encoding, which would be used in the creation of the java.io.Writer that wraps the OutputStream, but that is about it.
> The code is also brittle with respect to whether the values set are default values or explicit values,
> say from a stylesheet or from JAXP APIs.
> In the long run many methods on the serializer's XSLOutputAttributes interface should go away.
> In their place a more generic methods should exist:
> public void setOutputPropertyDefault(String name, String val);
> public void setOutputProperty(String name, String val);
> public String getOutputPropertyDefault(String name);
> public String getOutputProperty(String name);
> Through these methods one can set/get a default or non-default property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org