[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1788: [Feature][Seatunnel-core-flink/spark] format usage help message

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #1788:
URL: https://github.com/apache/incubator-seatunnel/pull/1788#discussion_r865518526


##########
seatunnel-core/seatunnel-core-flink/src/test/java/org/apache/seatunnel/core/flink/utils/CommandLineUtilsTest.java:
##########
@@ -44,6 +44,10 @@ public void testParseCommandArgs() {
         Assert.assertEquals(flinkCommandArgs.getFlinkParams(), Arrays.asList("--detached", "--unkown", "unkown-command"));
         Assert.assertEquals(flinkCommandArgs.getRunMode(), FlinkRunMode.APPLICATION_RUN);
         Assert.assertEquals(flinkCommandArgs.getVariables(), Arrays.asList("city=shenyang", "date=20200202"));
+
+        String[] args2 = {"-h"};
+        flinkCommandArgs = CommandLineUtils.parseCommandArgs(args2, FlinkJobType.SQL);
+        Assert.assertTrue(flinkCommandArgs.isHelp());

Review Comment:
   This test case need to be removed, since this will close the JVM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org